From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] lint: add 'source' checker.
Date: Mon, 29 Dec 2014 15:23:25 +0100 [thread overview]
Message-ID: <871tni357m.fsf@gnu.org> (raw)
In-Reply-To: <1419824407-6471-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Mon, 29 Dec 2014 04:40:07 +0100")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> * guix/scripts/lint.scm (uri-available?): New procedure.
> (%checkers): Add 'home-page' checker
Some comments in addition to what David already wrote.
> +(define (uri-available? uri)
> + "Return #t if the given URI can be reached, otherwise throw a
> +'not-available exception along with an appropriate error message."
By convention, one would expect ‘uri-available?’ to return #t or #f, not
to throw.
How about calling it ‘validate-uri’ and directly call ‘emit-warning’
from there? It would need the field name as an additional argument.
> + (let-values (((status argument)
> + (probe-uri uri)))
> + (case status
> + ((http-response)
IMO ‘case’ is fine here.
> +(define (check-source package)
> + ""
Missing docstring.
Thanks!
Ludo’.
next prev parent reply other threads:[~2014-12-29 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 17:02 New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 3:08 ` Cyril Roelandt
2014-12-29 3:40 ` [PATCH] lint: add 'source' checker Cyril Roelandt
2014-12-29 13:05 ` David Thompson
2014-12-29 14:23 ` Ludovic Courtès [this message]
2015-01-03 2:43 ` Cyril Roelandt
2015-01-03 19:11 ` Ludovic Courtès
2014-12-29 20:32 ` Ludovic Courtès
2015-01-15 7:52 ` [PATCHv2] " Cyril Roelandt
2015-01-15 21:58 ` Ludovic Courtès
2015-01-23 9:56 ` Ludovic Courtès
2015-01-25 17:43 ` Cyril Roelandt
2014-12-29 14:18 ` New home-page checker for ‘guix lint’ Ludovic Courtès
2014-12-29 20:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tni357m.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.