From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add AlsaModularSynth.
Date: Wed, 25 Feb 2015 15:00:16 +0100
Message-ID: <871tlexf9r.fsf@gnu.org>
References: <1424552053-17323-1-git-send-email-rekado@elephly.net>
	<1424552053-17323-2-git-send-email-rekado@elephly.net>
	<878ufr6kf0.fsf@mango.localdomain> <87h9udbraa.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQcVk-0005EJ-Oz
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:00:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQcVe-0004yB-JU
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:00:24 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37087)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YQcVe-0004y7-Ha
	for guix-devel@gnu.org; Wed, 25 Feb 2015 09:00:18 -0500
In-Reply-To: <87h9udbraa.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Sun, 22 Feb 2015 21:54:53 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 79a6aa562688c02bd4c50035a971478a2f2331e1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 21 Feb 2015 21:52:10 +0100
> Subject: [PATCH 1/2] gnu: Add zita-alsa-pcmi.
>
> * gnu/packages/audio.scm (zita-alsa-pcmi): New variable.

[...]

> +    (license license:gpl3)))

GPLv3-only?

> From ca099ed2ea8f270ca0e980b17599895f39489d61 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 21 Feb 2015 21:53:02 +0100
> Subject: [PATCH 2/2] gnu: Add AlsaModularSynth.
>
> * gnu/packages/audio.scm (alsa-modular-synth): New variable.

[...]

> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("fftw" ,fftw)
> +       ("jack" ,jack-1)
> +       ("ladspa" ,ladspa)
> +       ("liblo" ,liblo)
> +       ("qt" ,qt-4)
> +       ("zita-alsa-pcmi" ,zita-alsa-pcmi)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "http://alsamodular.sourceforge.net/")
> +    (synopsis "Realtime modular synthesizer and effect processor")
> +    (description
> +     "AlsaModularSynth is a digital implementation of a classical analog
> +modular synthesizer system.  It uses virtual control voltages to control=
 the
> +parameters of the modules.  The control voltages which control the frequ=
ency
> +e.g. of the VCO (Voltage Controlled Oscillator) and VCF (Voltage Control=
led
> +Filter) modules follow the convention of 1V / Octave.")
> +    (license license:gpl2)))

This one must be GPLv2+, otherwise there=E2=80=99d be problems combining it=
 with
the first one.

Other than that LGTM.

Thanks!

Ludo=E2=80=99.