Re: [PATCH 2/2] gnu: Add AlsaModularSynth.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 79a6aa562688c02bd4c50035a971478a2f2331e1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 21 Feb 2015 21:52:10 +0100
> Subject: [PATCH 1/2] gnu: Add zita-alsa-pcmi.
>
> * gnu/packages/audio.scm (zita-alsa-pcmi): New variable.

[...]

> +    (license license:gpl3)))

GPLv3-only?

> From ca099ed2ea8f270ca0e980b17599895f39489d61 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 21 Feb 2015 21:53:02 +0100
> Subject: [PATCH 2/2] gnu: Add AlsaModularSynth.
>
> * gnu/packages/audio.scm (alsa-modular-synth): New variable.

[...]

> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("fftw" ,fftw)
> +       ("jack" ,jack-1)
> +       ("ladspa" ,ladspa)
> +       ("liblo" ,liblo)
> +       ("qt" ,qt-4)
> +       ("zita-alsa-pcmi" ,zita-alsa-pcmi)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "http://alsamodular.sourceforge.net/")
> +    (synopsis "Realtime modular synthesizer and effect processor")
> +    (description
> +     "AlsaModularSynth is a digital implementation of a classical analog
> +modular synthesizer system.  It uses virtual control voltages to control the
> +parameters of the modules.  The control voltages which control the frequency
> +e.g. of the VCO (Voltage Controlled Oscillator) and VCF (Voltage Controlled
> +Filter) modules follow the convention of 1V / Octave.")
> +    (license license:gpl2)))

This one must be GPLv2+, otherwise there’d be problems combining it with
the first one.

Other than that LGTM.

Thanks!

Ludo’.