From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add xcape.
Date: Mon, 16 Mar 2015 15:53:34 +0100
Message-ID: <871tkpat8x.fsf@mango.localdomain>
References: <CAJpGxxDaEUyQoBLyB4mt_p2AwTziomGMCG=bN8wXaO310RHyXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YXWOw-0006qR-V7
	for guix-devel@gnu.org; Mon, 16 Mar 2015 10:53:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YXWOr-0001WQ-2p
	for guix-devel@gnu.org; Mon, 16 Mar 2015 10:53:54 -0400
Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:55283)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YXWOq-0001Vy-P8
	for guix-devel@gnu.org; Mon, 16 Mar 2015 10:53:48 -0400
In-Reply-To: <CAJpGxxDaEUyQoBLyB4mt_p2AwTziomGMCG=bN8wXaO310RHyXw@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Axel <grafov@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>


> From 0ad9b0eea2cd6151072d27f5e2505db9db083b37 Mon Sep 17 00:00:00 2001
> From: "Alexander I.Grafov (Axel)" <grafov@gmail.com>
> Date: Sun, 15 Mar 2015 20:01:03 +0300
> Subject: [PATCH] gnu: Add xcape.
> 
> * gnu/packages/xdisorg.scm (xcape): New variable.
> ---
> +
> +(define-public xcape
> +  (package
> +    (name "xcape")
> +    (version "1.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +              "https://github.com/alols/"
> +              name
> +              "/archive/v"
> +              version
> +              ".tar.gz"))

As the tarball does not include the name of the package you should
probably add something like this:

    (file-name (string-append name "-" version ".tar.gz"))

> +    (arguments
> +     `(#:tests? #f ; no test target
> +       #:phases (alist-replace
> +                 'configure
> +                 (let ((out (assoc-ref %outputs "out")))
> +                   (lambda _
> +                     (substitute* "Makefile"
> +                       (("(PREFIX[[:blank:]]*=.*)")
> +                        (string-append "CC:=gcc\nPREFIX=" out "\n"))
> +                       (("(MANDIR.*=.*)")
> +                        (string-append "MANDIR=/share/man/man1\n")))))

Is this really necessary or could you just set these variables as
make-flags?

    #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
                       "CC=gcc"
                       ...)

~~ Ricardo