all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] tests: Use '.' and not 'source' which is a Bashism.
@ 2015-05-06 18:18 Taylan Ulrich Bayırlı/Kammer
  2015-05-06 19:32 ` John Darrington
  0 siblings, 1 reply; 5+ messages in thread
From: Taylan Ulrich Bayırlı/Kammer @ 2015-05-06 18:18 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

I assume the test is supposed to run with any standards compliant shell
and not specifically GNU Bash:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-tests-Use-.-and-not-source-which-is-a-Bashism.patch --]
[-- Type: text/x-diff, Size: 1061 bytes --]

From 45b02e923e835569c47e4e5b4dd6972ac402a74e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Wed, 6 May 2015 20:13:31 +0200
Subject: [PATCH] tests: Use '.' and not 'source' which is a Bashism.

* tests/profiles.scm ("etc/profile"): Use '.' instead of 'source', since the
  latter is a Bashism and not necessarily supported by a standard shell.
---
 tests/profiles.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/profiles.scm b/tests/profiles.scm
index a397171..93801a0 100644
--- a/tests/profiles.scm
+++ b/tests/profiles.scm
@@ -237,8 +237,7 @@
     (mbegin %store-monad
       (built-derivations (list drv))
       (let* ((pipe (open-input-pipe
-                    (string-append "source "
-                                   profile "/etc/profile; "
+                    (string-append ". " profile "/etc/profile; "
                                    "unset GUIX_PROFILE; set")))
              (env  (get-string-all pipe)))
         (return
-- 
2.2.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-05-06 20:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-06 18:18 [PATCH] tests: Use '.' and not 'source' which is a Bashism Taylan Ulrich Bayırlı/Kammer
2015-05-06 19:32 ` John Darrington
2015-05-06 20:08   ` Taylan Ulrich Bayırlı/Kammer
2015-05-06 20:17     ` Ludovic Courtès
2015-05-06 20:36       ` Taylan Ulrich Bayırlı/Kammer

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.