From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] guix environment: Add --ad-hoc option.
Date: Thu, 28 May 2015 23:53:12 +0200
Message-ID: <871ti0tlmf.fsf@gnu.org>
References: <87d21kg98b.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yy5jr-0004WQ-Bn
	for guix-devel@gnu.org; Thu, 28 May 2015 17:53:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yy5jo-00028L-6G
	for guix-devel@gnu.org; Thu, 28 May 2015 17:53:19 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43551)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yy5jo-00028H-2n
	for guix-devel@gnu.org; Thu, 28 May 2015 17:53:16 -0400
In-Reply-To: <87d21kg98b.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Thu, 28 May 2015 08:47:00 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> I find myself frequently wanting to quickly create an environment with
> just a few packages in it, without having to go through the song and
> dance of creating a package expression for it.  This patch addresses
> this use-case.

Yeah, nice!

> From 30a5b0f61e5c4a0e0244015f127ba3255f834139 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Thu, 28 May 2015 08:41:04 -0400
> Subject: [PATCH] guix environment: Add --ad-hoc option.
>
> * guix/scripts/environment.scm (%options): Add "ad-hoc" option.
>   (show-help): Display help for "--ad-hoc".
>   (packages+propagated-inputs): New procedure.
>   (guix-environment): Create ad hoc environment when asked.
> * doc/guix.texi ("invoking guix environment"): Document it.

LGTM!

> +@item --ad-hoc
> +Include all specified packages in the resulting environment, as if an ad
> +hoc package were defined with them as inputs.  This option is useful for

@i{ad hoc}

> +quickly creating an environment without having to write a package
> +expression to contain the desired inputs.

Maybe add an example, like:

  For instance, the command:

  @example
  guix environment --ad-hoc guile guile-sdl -E guile
  @end example

  runs @command{guile} in an environment where Guile and Guile-SDL are
  available.

OK with these changes.

Thank you!

Ludo=E2=80=99.