all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add cufflinks.
Date: Wed, 16 Sep 2015 19:10:08 +0200	[thread overview]
Message-ID: <871tdycmtr.fsf@gnu.org> (raw)
In-Reply-To: <idjpp1i74gl.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Wed, 16 Sep 2015 17:45:46 +0200")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From e8186326701df11ee4bdb22d4717cf4b8c27dd50 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 16 Sep 2015 17:42:41 +0200
> Subject: [PATCH] gnu: Add cufflinks.
>
> * gnu/packages/bioinformatics.scm (boost-1.55, cufflinks): New
>   variables.

[...]

> +(define boost-1.55
> +  (package (inherit boost)

I would keep it next to ‘boost’.


[...]

> +          (lambda* (#:key inputs #:allow-other-keys)
> +            ;; The includes for "eigen" are located in a subdirectory.
> +            (setenv "CPATH" (string-append (assoc-ref inputs "eigen")
> +                                           "/include/eigen3/" ":"
> +                                           (or (getenv "CPATH") "")))

It should be using ‘pkg-config eigen3 --cflags’, but pkg-config is
missing.

Could you check if adding pkg-config makes this hack unnecessary?

Otherwise LGTM.

Thanks,
Ludo’.

  reply	other threads:[~2015-09-16 17:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 15:45 [PATCH] Add cufflinks Ricardo Wurmus
2015-09-16 17:10 ` Ludovic Courtès [this message]
2015-09-16 19:56   ` Andreas Enge
2015-09-16 20:06     ` Ludovic Courtès
2015-09-16 20:07     ` Ricardo Wurmus
2016-01-23  8:14   ` Ricardo Wurmus
  -- strict thread matches above, loose matches on Subject: below --
2016-01-20 10:02 [PATCH 0/1] Provide icons for transmission-gtk Leo Famulari
2016-01-20 10:02 ` [PATCH 1/1] gnu: transmission-gtk: Add icon dependencies Leo Famulari
2016-01-22 17:15   ` Ludovic Courtès
2016-01-22 19:27     ` Leo Famulari
2016-01-23 16:36       ` Ludovic Courtès
2016-01-23 18:11         ` Add "guix update" command Fabian Harfert
2016-01-23 18:28           ` Friedrich Herbst
2016-01-23 19:37           ` Thompson, David
2016-01-23 21:35             ` Ludovic Courtès
2016-01-28  4:44         ` [PATCH 1/1] gnu: transmission-gtk: Add icon dependencies Leo Famulari
2016-01-31  9:38           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tdycmtr.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.