From: Mathieu Lirzin <mthl@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add python-xlrd.
Date: Thu, 01 Oct 2015 23:48:56 +0200 [thread overview]
Message-ID: <871tdegszb.fsf@openmailbox.org> (raw)
In-Reply-To: <87wpvby668.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 27 Sep 2015 22:10:39 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
>
>> On 20/09/15 06:37, Mathieu Lirzin wrote:
>>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>>
>>>> Mathieu Lirzin <mthl@openmailbox.org> writes:
>>>>
>>>>>> + ;; so use nose to run tests instead for now.
>>>>>> + (replace 'check (lambda _ (zero? (system* "nosetests")))))))
>>>>>> + (native-inputs
>>>>>> + `(("python-setuptools" ,python2-setuptools)
>>>>>> + ("python-nose" ,python2-nose)))
>>>>> I don't know python packaging but when I look at other packages it
>>>>> seems that these are usually used as “inputs” not
>>>>> “native-inputs”.
>>>> Nose is used for the tests only and setuptools is used at build time, so
>>>> I think it’s fine like this.
>>> Is this a general statement or something specific to this package? If
>>> this is general it seems to be a good idea to make a big commit that
>>> fixes all the python packages which use these dependencies as normal
>>> inputs? WDYT?
>> If someone were to change things wholesale, it might also be a good
>> idea to change the pypi importer to match.
>>
>> Let me know when you want me to send an updated patch - all your
>> comments look good to me Marthieu.
>
> Mathieu, Ricardo: It seems to me that this patch should go in. The
> other issues can be discussed separately IMO; WDYT?
Pushed with the changes in 02a8a1876a9facd52fa71e76a5fdab8c97063eca
sorry for the delay. Thanks Ben.
--
Mathieu Lirzin
next prev parent reply other threads:[~2015-10-01 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 13:38 [PATCH] gnu: Add python-xlrd Ben Woodcroft
2015-09-19 15:49 ` Mathieu Lirzin
2015-09-19 15:53 ` Andreas Enge
2015-09-19 20:08 ` Ricardo Wurmus
2015-09-19 20:37 ` Mathieu Lirzin
2015-09-20 0:48 ` Ben Woodcroft
2015-09-27 20:10 ` Ludovic Courtès
2015-10-01 21:48 ` Mathieu Lirzin [this message]
2015-09-20 7:41 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tdegszb.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.