From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 03/05: gnu: icedtea6, icedtea7: Rename package to "icedtea". Date: Fri, 08 Jan 2016 18:17:43 -0500 Message-ID: <871t9r3bl4.fsf@netris.org> References: <20160106103859.32342.11104@vcs.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHgIJ-0002Do-P2 for guix-devel@gnu.org; Fri, 08 Jan 2016 18:18:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHgIE-0006fi-LF for guix-devel@gnu.org; Fri, 08 Jan 2016 18:18:07 -0500 Received: from world.peace.net ([50.252.239.5]:51896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHgIE-0006fU-HM for guix-devel@gnu.org; Fri, 08 Jan 2016 18:18:02 -0500 In-Reply-To: (Ricardo Wurmus's message of "Wed, 06 Jan 2016 10:39:00 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > rekado pushed a commit to branch master > in repository guix. > > commit 5452588c1a662bdcee240342a9df87efa4b1c017 > Author: Ricardo Wurmus > Date: Wed Dec 30 14:31:16 2015 +0100 > > gnu: icedtea6, icedtea7: Rename package to "icedtea". > > * gnu/packages/java.scm (icedtea6): Change package name to "icedtea". > (icedtea7): Inherit package name. This broke the builds for icedtea-1.13.9, see: http://hydra.gnu.org/eval/108721#tabs-new http://hydra.gnu.org/build/908975/log/tail-reload The relevant excerpt is: --8<---------------cut here---------------start------------->8--- In unknown file: ?: 0 [chdir "icedtea-1.13.9"] ERROR: In procedure chdir: ERROR: In procedure chdir: No such file or directory builder for `/gnu/store/dl93r8kpd9g7g3iamwz2n05nxlwjsfsn-icedtea-1.13.9.drv' failed with exit code 1 --8<---------------cut here---------------end--------------->8--- I guess the problem is that the custom unpack phase does this: (chdir (string-append ,name "-" ,version)) and this patch changes the value of 'name'. Regards, Mark > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index c4ad45e..b4c7bc3 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -186,7 +186,7 @@ build process and its dependencies, whereas Make uses Makefile format.") > > (define-public icedtea6 > (package > - (name "icedtea6") > + (name "icedtea") > (version "1.13.9") > (source (origin > (method url-fetch) > @@ -514,7 +514,8 @@ build process and its dependencies, whereas Make uses Makefile format.") > (alist-replace > 'install > (lambda* (#:key outputs #:allow-other-keys) > - (let ((doc (string-append (assoc-ref outputs "doc") "/share/doc/" ,name)) > + (let ((doc (string-append (assoc-ref outputs "doc") > + "/share/doc/icedtea")) > (jre (assoc-ref outputs "out")) > (jdk (assoc-ref outputs "jdk"))) > (copy-recursively "openjdk.build/docs" doc) > @@ -585,7 +586,6 @@ build process and its dependencies, whereas Make uses Makefile format.") > "/icedtea7/" version "/" name ".tar.bz2")) > (sha256 (base32 hash)))))) > (package (inherit icedtea6) > - (name "icedtea7") > (version version) > (source (origin > (method url-fetch)