From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'.
Date: Sun, 10 Jan 2016 21:36:37 +0100
Message-ID: <871t9p41ey.fsf@gnu.org>
References: <9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name>
	<8737ubhu9z.fsf@gnu.org> <20160107073002.GA31830@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIMjD-0000iq-1L
	for guix-devel@gnu.org; Sun, 10 Jan 2016 15:36:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIMj9-0002Nl-Rk
	for guix-devel@gnu.org; Sun, 10 Jan 2016 15:36:42 -0500
In-Reply-To: <20160107073002.GA31830@jasmine> (Leo Famulari's message of "Thu,
	7 Jan 2016 02:30:02 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Jan 06, 2016 at 11:33:28AM +0100, Ludovic Court=C3=A8s wrote:
>> Leo Famulari <leo@famulari.name> skribis:
>>=20
>> > * gnu/packages/patches/w3m-fix-compile.patch: Update to work with -p1.
>> > * gnu/packages/w3m.scm (w3m): Drop patch flag -p0.
>>=20
>> I would rename the patch to, say, =E2=80=98w3m-libgc.patch=E2=80=99, for=
 clarity.
>>=20
>> > --- a/gnu/packages/patches/w3m-fix-compile.patch
>> > +++ b/gnu/packages/patches/w3m-fix-compile.patch
>> > @@ -1,15 +1,27 @@
>> > +From 371f256f5f300b01be228a6fd95884ea475965fc Mon Sep 17 00:00:00 2001
>> > +From: Leo Famulari <leo@famulari.name>
>> > +Date: Tue, 5 Jan 2016 16:57:29 -0500
>> > +Subject: [PATCH 1/4] fix compile
>> > +
>> >  https://bugs.archlinux.org/task/33397
>>=20
>> Could you remove the Git header and write something like:
>>=20
>>   This patch fixes w3m compilation with libgc > X.Y.
>>=20
>> (If I understand correctly what it does.)
>
> Done.
>
>>=20
>> However, I=E2=80=99m surprised this is needed since libgc hasn=E2=80=99t=
 changed lately?
>
> It's for libgc-7.2, released 2012-05-11.
>
> You may also notice the substitution of "file_handle" in w3m's package
> definition. That's because glibc decided to start using the identifier
> "file_handle" in 2011 [0]. The problem was reported to w3m on the last
> day of 2011 [1]. It was patched in the distros in 2012 but nothing from
> upstream.

OK.  Thanks for the explanation.

Ludo=E2=80=99.