Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'.

[ludo@gnu.org (Ludovic Courtès)]

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Jan 06, 2016 at 11:33:28AM +0100, Ludovic Courtès wrote:
>> Leo Famulari <leo@famulari.name> skribis:
>> 
>> > * gnu/packages/patches/w3m-fix-compile.patch: Update to work with -p1.
>> > * gnu/packages/w3m.scm (w3m): Drop patch flag -p0.
>> 
>> I would rename the patch to, say, ‘w3m-libgc.patch’, for clarity.
>> 
>> > --- a/gnu/packages/patches/w3m-fix-compile.patch
>> > +++ b/gnu/packages/patches/w3m-fix-compile.patch
>> > @@ -1,15 +1,27 @@
>> > +From 371f256f5f300b01be228a6fd95884ea475965fc Mon Sep 17 00:00:00 2001
>> > +From: Leo Famulari <leo@famulari.name>
>> > +Date: Tue, 5 Jan 2016 16:57:29 -0500
>> > +Subject: [PATCH 1/4] fix compile
>> > +
>> >  https://bugs.archlinux.org/task/33397
>> 
>> Could you remove the Git header and write something like:
>> 
>>   This patch fixes w3m compilation with libgc > X.Y.
>> 
>> (If I understand correctly what it does.)
>
> Done.
>
>> 
>> However, I’m surprised this is needed since libgc hasn’t changed lately?
>
> It's for libgc-7.2, released 2012-05-11.
>
> You may also notice the substitution of "file_handle" in w3m's package
> definition. That's because glibc decided to start using the identifier
> "file_handle" in 2011 [0]. The problem was reported to w3m on the last
> day of 2011 [1]. It was patched in the distros in 2012 but nothing from
> upstream.

OK.  Thanks for the explanation.

Ludo’.