From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add guile-gnome Date: Fri, 10 Jun 2016 11:44:21 +0300 Message-ID: <871t458mca.fsf@gmail.com> References: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org> <87y46ui2uk.fsf@gnu.org> <87ziqwkhkw.fsf@auf.org> <87vb1jhl7w.fsf@gnu.org> <87y46fk2k7.fsf@auf.org> <20160608173726.3f5597e4@capac> <20160609063753.GA513@debian-netbook> <20160609164552.6097b2b6@capac> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBI3D-0004F2-6S for guix-devel@gnu.org; Fri, 10 Jun 2016 04:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBI38-0006Gm-6t for guix-devel@gnu.org; Fri, 10 Jun 2016 04:44:23 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:35202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBI37-0006Gg-Ui for guix-devel@gnu.org; Fri, 10 Jun 2016 04:44:18 -0400 Received: by mail-lf0-x22d.google.com with SMTP id u74so41698705lff.2 for ; Fri, 10 Jun 2016 01:44:17 -0700 (PDT) In-Reply-To: <20160609164552.6097b2b6@capac> (David Pirotte's message of "Thu, 9 Jun 2016 16:45:52 -0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Pirotte Cc: Patrick Hetu , guix-devel@gnu.org David Pirotte (2016-06-09 22:45 +0300) wrote: >> > > ... >> > > + (modify-phases %standard-phases >> > > + (add-before 'configure 'pre-configure >> > > + (lambda* (#:key outputs #:allow-other-keys) >> > > + (let ((out (assoc-ref outputs "out"))) >> > > + (substitute* (find-files "." "^Makefile.in$") >> > > + (("guilemoduledir =.*guile/site" all) >> > > + (string-append all "/2.0"))) >> > > + #t)))))) >> > > ... > >> > Just curious: why do you (string-append all "/2.0")? Is this a guix guideline >> > maybe? > >> > IMO, G-wrap, Guile-Cairo and Guile-Gnome should all be installed in the >> > directory returned by (%global-site-dir) > >> `guilemoduledir =.*guile/site' is saved in the variable `all' and then >> used in the second half of the substitute*. I have a similar one I >> wrote for aria2 in bittorrent.scm > > ok, but why "/2.0" is appended to it? I think the version is not needed, but Ludovic had another opinion. I don't remember details but there was some discussion about it: -- Alex