From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: Review process Date: Sun, 24 Jul 2016 12:38:25 +0200 Message-ID: <871t2jxqvy.fsf@gnu.org> References: <579027b7.VHXjhpPxQC3AAmeY%pjotr.public12@email> <8760rznoh1.fsf@gnu.org> <20160722004130.GA10340@thebird.nl> <874m7hk6dz.fsf_-_@gnu.org> <20160723022421.GA15436@thebird.nl> <878twsg1xb.fsf@gmail.com> <87k2gc3cn8.fsf@gnu.org> <87poq3cvkz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRGnu-0003Lk-BB for guix-devel@gnu.org; Sun, 24 Jul 2016 06:38:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRGns-0005Nf-AN for guix-devel@gnu.org; Sun, 24 Jul 2016 06:38:37 -0400 In-Reply-To: <87poq3cvkz.fsf@gmail.com> (Alex Kost's message of "Sun, 24 Jul 2016 11:02:36 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost writes: > Mathieu Lirzin (2016-07-23 12:51 +0300) wrote: > >> Alex Kost writes: >> >>> Pjotr Prins (2016-07-23 05:24 +0300) wrote: >>> >>>> Thanks Ludo. As it stands I am no longer submitting packages to ML. I >>>> did my utmost to make the package lean and clean. This package is not >>>> going in. >>>> >>>> But, I suggest you listen. I know at least 4 people here who say they >>>> have trouble submitting to Guix. Good people. >>> >>> 5 including me :-) I always feel big inconveniences sending patches, and >>> I don't like that the development happens on mailing list. However >>> unlike Pjotr and Jookia I think it's my problem, not the one of the Guix >>> community. >>> >>> I just wrote this because I'm almost sure that some day I will maintain >>> emacs interface separately from Guix again. I've been regretting all >>> the time that it became a part of Guix. >> >> I am interested to know what do you miss from that the period you were >> maintaining it separately? > > Oh, this is easy: if I maintain something myself, I don't ask anyone, I > just commit whatever seems appropriate to me, and that's it. When I > send patches for emacs UI to the mailing list, it's like I ask > permissions to modify a part of code I wrote. Sure, I understand this can feel frustrating. > Also I always have a bad feeling that I load Ludovic (who is the only > person reviewing these patches) with a useless additional work. I am confident that Ludovic doesn't think of your patches that way. > Finally, I feel like I clog the mailing list with my patches. Sometimes > I want to make some small change, but then I think: =C2=ABAh, it's not so > big, no one will ever notice it anyway, so I wouldn't bother people with > it.=C2=BB (although recently myglc2 noticed several such things :-)) Maybe you could view your patches for emacs UI has a buffer with an "LGTM" default that you can push for example 1 week later. It gives others a chance to comment on potential controversial changes and gives you a chance to improve them, without feeling that you are asking permission. What do others think? Even if I am not very active in reviewing/commenting your patches, I appreciate the fact that Emacs UI is included in Guix source tree because it feels integrated and is ready to hack for any Guix contributor. I hope this will continue. Thanks for sharing your thoughts. --=20 Mathieu Lirzin