From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add p7zip. Date: Tue, 9 Aug 2016 10:05:41 +0200 Message-ID: <871t1y74fe.fsf@mdc-berlin.de> References: <87a8gwxa9c.fsf@openmailbox.org> <87y44f4plm.fsf@mdc-berlin.de> <20ae08af155acdc7edd02b68afb9e66d@openmailbox.org> <20160808195835.GF18650@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX237-0000fR-Ce for guix-devel@gnu.org; Tue, 09 Aug 2016 04:06:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX232-0001SH-CX for guix-devel@gnu.org; Tue, 09 Aug 2016 04:06:09 -0400 In-Reply-To: <20160808195835.GF18650@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org, Guix-devel Leo Famulari writes: >> > I see that you took care of removing non-free parts in a patch and a >> > build phase. Since =E2=80=9Cguix build -S p7zip=E2=80=9D doesn=E2=80= =99t run the build phase >> > users would still end up with a source archive containing the non-fr= ee >> > parts. The best way is thus to remove things in a snippet. >> >=20 >> > In =E2=80=9Cshogun=E2=80=9D from the =E2=80=9Cmachine-learning=E2=80= =9D module we remove supporting code >> > for non-free features in a snippet by cutting out anything between s= ome >> > ifdef markers, but looking at the patch I see that it wouldn=E2=80=99= t be >> > feasible for p7zip. >>=20 >> Also note that it is not completely desirable for nonfree code to be r= emoved >> with a patch, and is one of the reasons Guix supports snippets in the = first >> place. > > Is there a reason to not use a patch in this case? Or can we proceed > with packaging p7zip, using a patch to remove non-free parts? We don=E2=80=99t want to have a =E2=80=9Creverse image=E2=80=9D of the no= n-free code in a patch. Arguably that would just be a derivative of the non-free code, so we also couldn=E2=80=99t freely distribute it. We have to distinguish between code under a non-free license and bits and pieces that refer to non-free software. The former needs work as done in shogun where the latter can probably be removed with a simple patch in a snippet. ~~ Ricardo