Re: [PATCH] gnu: vlc: Add inputs.

[Alex Vong <alexvong1995@gmail.com>]

Hi David and Efraim,

Thanks for the review.

Efraim Flashner <efraim@flashner.co.il> writes:

> On Sat, Sep 03, 2016 at 06:15:48PM +0200, David Craven wrote:
>> Hi Alex,
>> 
>> I'm not sure we need all those dependencies =) Can you explain what
>> they are for? If you are adding dependencies to vlc why did you leave
>> libinput-minimal off the list? ;)
>>
Sorry, I don't understand what do you mean by libinput-minimal? I didn't
add any packages with a "-minial" suffice. As for the necessities of
those dependencies, those dependencies are added one by one. The
procedure is as followed:
1. I build from source and check for something like "WARNING: XXX not found"
2. Add dependency(s) to silent the warning
3. Repeat


>> > 3. Our vlc was built with fast-math disabled as explained in the
>> > comment. However, this is actually not necessary, vlc would built with
>> > '-ffast-math -fno-finite-math-only'.
>> 
>> This should probably be a separate patch, and will probably have a
>> easier path to master...
>>
Sure!

>> Thanks!
>> 
>
> also check the closure size with and without samba. A long time ago we
> removed samba from mpv and it drastically slimmed down the size of the
> closure. IIRC it meant we could no longer do `mpv smb://...'

I haven't checked that. I will check it now.

Cheers,
Alex