From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [Patch 4/10] argon2: Install pkg-config file. Date: Sat, 17 Sep 2016 11:47:58 -0500 Message-ID: <871t0ixykh.fsf@openmailbox.org> References: <87mvjc1quq.fsf@openmailbox.org> <8737l41qnj.fsf@openmailbox.org> <20160915232412.6bcd757b@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blImi-0005AJ-Dl for guix-devel@gnu.org; Sat, 17 Sep 2016 12:48:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blImf-0000h0-05 for guix-devel@gnu.org; Sat, 17 Sep 2016 12:48:12 -0400 Received: from smtp13.openmailbox.org ([62.4.1.47]:34003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blIme-0000gB-Ke for guix-devel@gnu.org; Sat, 17 Sep 2016 12:48:08 -0400 In-Reply-To: <20160915232412.6bcd757b@scratchpost.org> (Danny Milosavljevic's message of "Thu, 15 Sep 2016 23:24:12 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Thank you for your review! Danny Milosavljevic writes: >> + (snippet >> + '(let ((p (open-file "argon2.pc" "a"))) > ... ^ why? > >> + (begin >> + (display >> + (string-append "prefix=/usr/local\n" >> + "exec_prefix=${prefix}\n" >> + "includedir=${prefix}/include\n" >> + "libdir=${prefix}/lib\n\n" >> + "Name: Argon2\n" >> + "Description: " >> + "The Argon2 password hashing algorithm\n" >> + "Version: 1.0.0\n" >> + "Cflags: -I${includedir}/\n" >> + "Libs: -L${libdir} -largon2\n") p) >> + (close-output-port p)))) > > Ok but please try to upstream this as well. OK, I will look into that. > >> + (zero? (system* "ln" "-s" >> + (string-append out "/lib/libargon2.so") >> + (string-append out "/lib/libargon2.so.0"))) > > The result of this will be ignored. Did you mean "(and ...)"? Oops! Yes, I will send an updated patch later today. > >> + (zero? (system* ; Fix compatability for libtool based builds. >> + "ln" "-s" >> + (string-append out "/lib/libargon2.so") >> + (string-append out "/lib/libargon2.so.0.0.0"))))))))) > > Doesn't this have a soversion other than 0? I mean it's OK, I'm just > asking to be sure - because the pkg-config file lists 1.0.0 and the > name of the pkg-config file contains no soversion at all. I am actually not sure about this. I noticed that one of the packages that depends on opendht (I think libring, but need to make sure) is looking for 'libargon2.so.0.0.0'. I did not find a way to convince it to use 'libargon2.so' other than creating this symlink. I am not sure if this is a good/acceptable way to solve this, it is probably not the intended way. I also could not find documentation on this issue and i am not sure which part of the toolchain is responsible for making the '.so.X.X.X' versions of a library. Thank you! Best, Lukas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX3XO+AAoJEFP7dyh+2DCRyw8P/Rgpv6gFZHyo9Cqtax3IiXo4 RB7+3MSQfy1bz9P9eP8sFK5zN+WD1khVW/xkPaQte8OLDHdHhHyNkaD93yd+Mq5x OejlBxLnFNNj4/MMxflWMyOJjAQz2VaHkos0mpl/fVp2hhS/tuZAuDKrktMZ+nBn /cOlh7Y2eFv/q5qyRxTQW0gVNRJp+Qz5/wKcVEDxwp1aXCEV/EvoKz9S3AvtI2xb 8Jnhfk3U4mLz9kZ+77/yHMa7nIoHHoPFPJxNYhA29tcDzuVn/tLZs/IJojNYl20i QhdkF97tFzE5BZGcw6k1Ne3l7FDqFZaHTt47S+H8HcKf94ovBsEuSF5Y2DfxgPEF 01Os94Uzn+kDazY60oJD9nP0rHsfCxpgseEVNABsrQP+4PEPpaJXzerLPK6Z4KI7 7M1ns371EsUjqyvjyzSXxsxSqWhx4npE02iKLMpX4KiDLqmjvjAo6IcDlxJR/TBf nFwTzFuxNKZThvryM8vVyUmlr+mb33TERONS3AnHWzP3hp9bdBVmG+jzEt1FzAbY bbFervotQ3vXH3EZyeBjIyaMh/TCn++cH0SkM+cQYPsWkVok1qWfGh8UubW9yRmr nHIQo1F0KnT7UeoMluxAw84kCuTftIjgoBE9bDstFe8169N+7x/SG90tgyGjqWOo X1DzJ+CgDBgZi5s9XBzl =EiXy -----END PGP SIGNATURE----- --=-=-=--