From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 04/12] import: utils: Add spdx-string->license.
Date: Mon, 26 Sep 2016 11:33:48 +0200
Message-ID: <871t07ngu9.fsf@gnu.org>
References: <20160922131903.1606-1-david@craven.ch>
	<20160922131903.1606-4-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1boYAe-0003Hw-Di
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1boYAb-0004rj-TI
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:20 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:19383)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1boYAb-0004p1-Mq
	for guix-devel@gnu.org; Mon, 26 Sep 2016 11:50:17 -0400
In-Reply-To: <20160922131903.1606-4-david@craven.ch> (David Craven's message
	of "Thu, 22 Sep 2016 15:18:55 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * guix/import/utils.scm (spdx-string->license): New variable.

Eric wrote:

> SPDX seems to be a more general specification for licenses, but I
> still wonder whether its appropriate for (guix import utils), since
> its used only by the crate importer.

The generality is enough to put it here IMO, and npm appears to be using
it like David wrote.

> +(define (spdx-string->license str)
> +  "Convert STR, a SPDX formatted license identifier, to a license object.
                     ^^
Could you add the URL of the SPDX spec somewhere here?

> +   Return #f if STR does not match any known identifiers."
   ^^^
Extra space.

Otherwise LGTM, thanks!

Ludo=E2=80=99.