Re: [PATCH] gnu: Add coda.

[ludo@gnu.org (Ludovic Courtès)]

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> This is a C library wich also presents a python interface.  It can be
> used just as well without python, so I've made python only a native
> input, not a regular input.  There's currently a non-determinism issue
> for the python interface, related to
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22533
>
> I also tried to automatically generate the string
> “lib/python3.4/site-packages”, so it's updated automatically when the
> python version changes, but didn't manage to do that (for example I
> tried
>
>   (version-major+minor (package-version python))
>
> but the package variable “python” is not available when the build
> expression is turned into a derivation, as far as I understand
> it?). Advice welcome.

I think this is not needed; see below.

> From edb38dfcc09afdef4279728c84d10688b9d0fc71 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 19 Oct 2016 11:44:33 +0200
> Subject: [PATCH] gnu: Add coda.
>
> * gnu/packages/maths.scm (coda): New variable.

[...]

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "PYTHONPATH")
> +            (files '("lib/python3.4/site-packages")))))

Unless I’m mistaken this is not needed: this ‘native-search-paths’ entry
belongs in Python itself, not in users of Python.

> +    (synopsis "Common interface to various earth observation data formats")
> +    (description
> +     "The Common Data Access toolbox (CODA) provides a set of interfaces for
> +reading remote sensing data from earth observation data files.  These
> +interfaces consist of command line applications, libraries, interfaces to
> +scientific applications (such as IDL and MATLAB), and interfaces to

Let’s remove MATLAB; we can replace it with Octave if it’s valid.

> +    (license license:gpl2)))

Version 2 only?  That is, is the “or any later version” wording missing
from license headers?

Otherwise LGTM.

Could you send an updated patch?

Thank you!

Ludo’.