From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] mps-youtube Date: Wed, 02 Nov 2016 14:20:42 +0000 Message-ID: <871syuarph.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161102104057.8226-1-ng0@we.make.ritual.n0.is> <874m3qawmu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> <87twbqgf80.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1wPH-0002Ie-UA for guix-devel@gnu.org; Wed, 02 Nov 2016 10:20:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1wPE-0000LS-Nu for guix-devel@gnu.org; Wed, 02 Nov 2016 10:20:47 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54389) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1wPE-0000LI-JW for guix-devel@gnu.org; Wed, 02 Nov 2016 10:20:44 -0400 In-Reply-To: <87twbqgf80.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ng0 writes: >>> So far they are in (inputs). Are those supposed to be installed by the = users themselves? >> >> For optional dependencies (i.e. if mps-youtube gracefully handles >> missing ffmpeg), leaving it up to the user is good (but then it should >> not be an input). For "hard" runtime dependencies, the absolute paths >> must be recorded so that they won't get garbage collected. >> > > With the info I gave above, I'd say I remove the dependencies > which are not found and add information to the description. > For example: =E2=80=A6 it can be used with either mpv or mplayer, for > optional format conversion you need to use ffmpeg. > > What do you think? That sounds sensible. It seems to handle the case where those are missing as well, which is good. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYGfY6AAoJEKKgbfKjOlT6dv4H/0JTlf7QUEZiZEDnWw3ic6m5 iduMF+o+GkRbhOJ/tSuQ/PG+ZN8J6kamf+9MOlW2/VQ3y/sRsvdr4J9oF31iCWv/ o9x6kXdukiUn3wbiY8/UDOWPnCWSxgewAw/R54AhlQ9ma+oaBnFxF7LDIeA0vq86 SfO0yWeezp1eUuOllDi5m2gYTv+Rito44nKJsX4jb9bDs6S4eb+RVODLfewbUGDB mNjWBAUnWPNB7PFqhpvoSQcPt4xAx5VZjKC3xQFapyKqQmnoSMG8dN5Q/xC5A/J2 38alJ1kJfxdrdjI6m1Xlo2nhw5u1Pr7OhwbqhpTjMq0A3x+rE6VB35AQP51UJr4= =XwLm -----END PGP SIGNATURE----- --=-=-=--