all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add unetbootin.
@ 2017-01-14 17:26 Jan Nieuwenhuizen
  2017-01-19 12:20 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Nieuwenhuizen @ 2017-01-14 17:26 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Hi,

Needed this to flash BIOS (ugh).

Greetings,
Jan


[-- Attachment #2: 0001-gnu-Add-unetbootin.patch --]
[-- Type: text/x-patch, Size: 3024 bytes --]

From 5aa1cad5c06dc62f477318f0a40aaf9608672b3b Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke@gnu.org>
Date: Sat, 14 Jan 2017 18:23:57 +0100
Subject: [PATCH] gnu: Add unetbootin.

* gnu/packages/disk.scm (unetbootin): New variable.
---
 gnu/packages/disk.scm | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index a4bb0be13..71595bf3c 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -4,7 +4,7 @@
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;; Copyright © 2016,2017 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;;
@@ -45,6 +45,7 @@
   #:use-module (gnu packages readline)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages qt)
   #:use-module (gnu packages xml))
 
 (define-public parted
@@ -329,3 +330,41 @@ project to detect and manipulate partition tables.  Optional file system tools
 permit managing file systems not included in libparted.")
     ;; The home page says GPLv2, but the source code says GPLv2+.
     (license license:gpl2+)))
+
+(define-public unetbootin
+  (package
+    (name "unetbootin")
+    (version "625")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/unetbootin/unetbootin/archive/"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "18857mq8a5wwacwb9a6nzm06znzw6md27rbqb72b1kzcpdf2cqqw"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; no tests exist
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key make-flags #:allow-other-keys)
+             (chdir "src/unetbootin")
+             (system* "lupdate" "unetbootin.pro")
+             (system* "lrelease" "unetbootin.pro")
+             (system* "qmake")))
+         (replace 'install
+                  (lambda* (#:key outputs #:allow-other-keys)
+                    (let* ((out (assoc-ref outputs "out"))
+                           (bin (string-append out "/bin")))
+                      (mkdir-p bin)
+                      (copy-file "unetbootin"
+                                 (string-append bin "/unetbootin"))))))))
+    (inputs
+     `(("qt-4" ,qt-4)))
+    (home-page "https://unetbootin.github.io/")
+    (synopsis "Create bootable live USB images")
+    (description
+     "UNetbootin creates bootable Live USB images.")
+    (license license:gpl2+)))
-- 
2.11.0


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]


-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: Add unetbootin.
  2017-01-14 17:26 [PATCH] gnu: Add unetbootin Jan Nieuwenhuizen
@ 2017-01-19 12:20 ` Ludovic Courtès
  2017-01-19 14:37   ` Marius Bakke
  2017-01-19 20:58   ` Jan Nieuwenhuizen
  0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2017-01-19 12:20 UTC (permalink / raw)
  To: Jan Nieuwenhuizen; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 58 bytes --]

Hi Jan!

I’d suggest these minor cosmetic changes:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1678 bytes --]

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 71595bf3c..d922914e9 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -337,7 +337,8 @@ permit managing file systems not included in libparted.")
     (version "625")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://github.com/unetbootin/unetbootin/archive/"
+              (uri (string-append
+                    "https://github.com/unetbootin/unetbootin/archive/"
                     version ".tar.gz"))
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
@@ -353,18 +354,19 @@ permit managing file systems not included in libparted.")
              (chdir "src/unetbootin")
              (system* "lupdate" "unetbootin.pro")
              (system* "lrelease" "unetbootin.pro")
-             (system* "qmake")))
+             (zero? (system* "qmake"))))
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin")))
                (mkdir-p bin)
-                      (copy-file "unetbootin"
-                                 (string-append bin "/unetbootin"))))))))
+               (install-file "unetbootin" bin)
+               #t))))))
     (inputs
      `(("qt-4" ,qt-4)))
     (home-page "https://unetbootin.github.io/")
     (synopsis "Create bootable live USB images")
     (description
-     "UNetbootin creates bootable Live USB images.")
+     "UNetbootin allows you to create bootable USB images from ISO-9660 CD/DVD
+images.")
     (license license:gpl2+)))

[-- Attachment #3: Type: text/plain, Size: 311 bytes --]


In addition, there’s one thing we need to fix from an FSDG perspective,
which is described here:
<https://libreplanet.org/wiki/Software_blacklist#unetbootin>.

Could you check whether the package can be adjusted to use this FUSBi
fork mentioned there, and send an updated patch?

TIA!

Ludo’.


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: Add unetbootin.
  2017-01-19 12:20 ` Ludovic Courtès
@ 2017-01-19 14:37   ` Marius Bakke
  2017-01-19 20:58   ` Jan Nieuwenhuizen
  1 sibling, 0 replies; 6+ messages in thread
From: Marius Bakke @ 2017-01-19 14:37 UTC (permalink / raw)
  To: Ludovic Courtès, Jan Nieuwenhuizen; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]


> Could you check whether the package can be adjusted to use this FUSBi
> fork mentioned there, and send an updated patch?

Also note that the unetbootin distribution bundles a *lot* of
executables. I'm not sure if it's usable without them, or if FUSBi has
the same problem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: Add unetbootin.
  2017-01-19 12:20 ` Ludovic Courtès
  2017-01-19 14:37   ` Marius Bakke
@ 2017-01-19 20:58   ` Jan Nieuwenhuizen
  2017-01-19 21:39     ` Adonay Felipe Nogueira
  1 sibling, 1 reply; 6+ messages in thread
From: Jan Nieuwenhuizen @ 2017-01-19 20:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Ludovic Courtès writes:

> I’d suggest these minor cosmetic changes:

Thanks, these are all fine...

> In addition, there’s one thing we need to fix from an FSDG perspective,
> which is described here:
> <https://libreplanet.org/wiki/Software_blacklist#unetbootin>.

Ouch, sorry.

> Could you check whether the package can be adjusted to use this FUSBi
> fork mentioned there, and send an updated patch?

I checked...FUSBi has been discontinued.  :-(

Possibly we can learn from other distros?  I checked if I could use
Debian (which I'm familiar with) but they do not have FUSBi and they
sadly also do not strip unetbootin; so this needs a little more
attention.

Greetings,
Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: Add unetbootin.
  2017-01-19 20:58   ` Jan Nieuwenhuizen
@ 2017-01-19 21:39     ` Adonay Felipe Nogueira
  2017-01-19 22:38       ` ng0
  0 siblings, 1 reply; 6+ messages in thread
From: Adonay Felipe Nogueira @ 2017-01-19 21:39 UTC (permalink / raw)
  To: guix-devel

We can take on the example of this fork instead: <https://trisquel.info/en/forum/unetbootin-fork>.
-- 
* pt-BR: Brasileiro | en: Brazilian
* pt-BR: Ativista do software livre | en: Free/libre software activist
* https://libreplanet.org/wiki/User:Adfeno
* pt-BR: Palestrante, consultor e avaliador | en: Speaker, consultant and evaluator

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: Add unetbootin.
  2017-01-19 21:39     ` Adonay Felipe Nogueira
@ 2017-01-19 22:38       ` ng0
  0 siblings, 0 replies; 6+ messages in thread
From: ng0 @ 2017-01-19 22:38 UTC (permalink / raw)
  To: guix-devel

Adonay Felipe Nogueira <adfeno@openmailbox.org> writes:

> We can take on the example of this fork instead: <https://trisquel.info/en/forum/unetbootin-fork>.
> -- 
> * pt-BR: Brasileiro | en: Brazilian
> * pt-BR: Ativista do software livre | en: Free/libre software activist
> * https://libreplanet.org/wiki/User:Adfeno
> * pt-BR: Palestrante, consultor e avaliador | en: Speaker, consultant and evaluator
>

Looks as if is semi-active/fallen-asleep aswell:
https://devel.trisquel.info/tomlukeywood/unetbootin_libre_edition

https://notabug.org/tomlukeywood/Unetbootin_Libre_Edition
disappeared aswell, but it went here:
https://notabug.org/tomlukeywood/FreeNetBootin

Maybe there's a patch/substitute way to do this and keep in sync
with upstream.
Last conversation on the  thread is from 2015-06-30, can one
of you people involved in trying to get unetbootin into Guix
contact the fork developer?
-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-01-19 22:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-14 17:26 [PATCH] gnu: Add unetbootin Jan Nieuwenhuizen
2017-01-19 12:20 ` Ludovic Courtès
2017-01-19 14:37   ` Marius Bakke
2017-01-19 20:58   ` Jan Nieuwenhuizen
2017-01-19 21:39     ` Adonay Felipe Nogueira
2017-01-19 22:38       ` ng0

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.