From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add emacs-aggresive-indent-mode. Date: Thu, 23 Mar 2017 19:13:07 +0100 Message-ID: <871stn6evg.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <39ee52d0-582a-77a3-39c0-b59b53b6048b@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr7Ea-0006K1-Bo for guix-devel@gnu.org; Thu, 23 Mar 2017 14:13:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cr7EV-0007BZ-AA for guix-devel@gnu.org; Thu, 23 Mar 2017 14:13:16 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cr7EU-0007BC-RV for guix-devel@gnu.org; Thu, 23 Mar 2017 14:13:11 -0400 In-Reply-To: <39ee52d0-582a-77a3-39c0-b59b53b6048b@yahoo.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vasile Dumitrascu , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vasile Dumitrascu writes: > * gnu/packages/emacs.scm (emacs-aggresive-indent-mode): New variable. Thanks! > --- > gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 547c44033..301552839 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -1066,6 +1066,31 @@ like. It can be linked with various Emacs mail > clients (Message and Mail > mode, Rmail, Gnus, MH-E, and VM). BBDB is fully customizable.") > (license license:gpl3+))) > > +(package Hmm. This should be enclosed in a 'define-public' block. > + (name "emacs-aggresive-indent-mode") ^^^ There should be an extra 's' here. Also '-mode' can be dropped. > + (version "1.8.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://elpa.gnu.org/packages/" > + "aggressive-indent-" version ".el")) > + (sha256 > + (base32 > + "0jnzccl50x0wapprgwxinp99pwwa6j43q6msn4gv437j7swy8wnj")))) > + (build-system emacs-build-system) > + (home-page "https://elpa.gnu.org/packages/aggressive-indent.html") > + (synopsis "Minor mode to aggressively keep your code always indented") > + (description > + "`electric-indent-mode' is enough to keep your code nicely aligned wh= en > +all you do is type. However, once you start shifting blocks around, > +transposing lines, or slurping and barfing sexps, indentation is bound > +to go wrong. > + > +`aggressive-indent-mode' is a minor mode that keeps your code always > +indented. It reindents after every change, making it more reliable > +than `electric-indent-mode'.") The quotes in the description should be replaced with @code{} blocks. Running `./pre-inst-env guix lint emacs-aggressive-indent` should warn about this. I also think that the second paragraph is sufficient. Can you send an updated patch? Please also add a copyright line for yourself at the top of the file. TIA! > + (license gpl2+)) > + > (define-public emacs-async > (package > (name "emacs-async") > --=20 > 2.11.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljUEDMACgkQoqBt8qM6 VPqIhQgAhz4685TPiTwdOiPfdjc/w8j9fJovMw5xa44JimE/q/O/XDxErvtW4aXY zXegoE+tV6ta7zlRT/h94Ushb0SdZK4s7myh9fihVbhkaQhFHoF5GtEJdGQBTx3E rAgJth/ZvK0W1hcK4SttAbE39t5yrxzEO4OA1TDYR4fLaFmejNYIKNTPofnUmzm+ bCUTIMmZYkzbf0Ddc8WfRvp+OUA6aXMo1x35pYoah1t8NB+6gjWycXW2F2fQ0y8g YMVmEdAGCxarE70B8E28Oto2ccqdZot3TO4ZAVqDNn/NFffGLTF9L6qAU+iWB0Qt N779EHtlm8+YXvHJ2J23pEisoYsUbQ== =GUFl -----END PGP SIGNATURE----- --=-=-=--