From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0EIZ-0005E3-CS for guix-patches@gnu.org; Mon, 17 Apr 2017 17:35:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0EIY-0000ND-8B for guix-patches@gnu.org; Mon, 17 Apr 2017 17:35:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0EIY-0000Ml-4u for guix-patches@gnu.org; Mon, 17 Apr 2017 17:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d0EIX-0003Tg-Qk for guix-patches@gnu.org; Mon, 17 Apr 2017 17:35:01 -0400 Subject: bug#26294: [PATCH] gnu: rocksdb: Disable tests on 32-bit systems. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87zifeoh8x.fsf@gnu.org> References: <20170329094220.5694-1-mbakke@fastmail.com> <87zifeoh8x.fsf@gnu.org> Date: Mon, 17 Apr 2017 23:34:56 +0200 Message-ID: <871ssqlnun.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26294@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > Marius Bakke skribis: > >> * gnu/packages/databases.scm (rocksdb)[arguments]: Make #:tests? conditi= onal. >> Delete unnecessary 'build' phase. >> --- >> gnu/packages/databases.scm | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm >> index b87e8a210..e73635910 100644 >> --- a/gnu/packages/databases.scm >> +++ b/gnu/packages/databases.scm >> @@ -533,12 +533,20 @@ types are supported, as is encryption.") >> #t)))) >> (build-system gnu-build-system) >> (arguments >> - '(#:make-flags (list "CC=3Dgcc" >> + `(#:make-flags (list "CC=3Dgcc" >> ;; Make the resulting library position-indepe= ndent so the >> ;; static version can be included in shared o= bjects. >> "EXTRA_CXXFLAGS=3D-fPIC" >> (string-append "INSTALL_PATH=3D" >> (assoc-ref %outputs "out"))) >> + ;; Many tests fail on 32-bit platforms. There are multiple repor= ts about >> + ;; this upstream, but it's not going to be supported any time so= on. >> + #:tests? (let ((system ,(or (%current-target-system) >> + (%current-system))) >> + (supported-systems '("x86_64-linux" "aarch64-linu= x"))) >> + (if (member system supported-systems) >> + #t >> + #f)) > > This doesn=E2=80=99t work because (%current-target-system) is a GNU tripl= et, > like =E2=80=9Carm-linux-gnueabihf=E2=80=9D, whereas (%current-system) is = a =E2=80=9Csystem > type=E2=80=9D, like =E2=80=9Carmhf-linux=E2=80=9D. > > Instead you should use =E2=80=98string-prefix?=E2=80=99 or similar. > > Other than that, I think it should go in! Well, I actually tried this recently (also disabling the individual tests, which was a rabbit hole that ultimately gave an inexplicable error). Anyway, when building for i686-linux on x86_64, the compiler appears to hit a never-ending loop at the linking stage! I'm pretty sure this was not the case before the core-updates merge (when I tested this), so I wonder if it's a case of https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26497 . To be continued, but now it would just cause the build to take up a CPU core until it times out, rather than failing early.. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlj1NQEACgkQoqBt8qM6 VPrXpwgAoL7EOPvrpzW0blrZT7hlwtfaro2tP/yO5SBP/y/ccUF1JA2SWdDo4ARX jOo+/Tci+DAzXDX165356HNNCzRfsOZ1kZ10ThyDS/VU/JVg3ju1XKqRuZOnVFoq 2LHBlzP2rk4s/F6A2nu+wqOOFW8pJE+xr0el3Wsarn/Wf3t6ozIlIWVLAokZSKHm MLqJHkNHqhI8XP1oDxeM6W55P9KBn4csXe0xGdhFQZrTHPQ2A5tS2x+IIjmD47aV KbyRH++KlSk4PH6SfK67jG00mZsXFAKD9J07/pAO8ev2nMAVF0cyVqsB9ert214E G8Mi2wZskHOXF4KaWECAL6OlH3cJ1w== =+0Lf -----END PGP SIGNATURE----- --=-=-=--