From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5Ulu-0006oZ-IR for guix-patches@gnu.org; Tue, 02 May 2017 06:11:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5Ulr-0001bu-CS for guix-patches@gnu.org; Tue, 02 May 2017 06:11:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5Ulr-0001bP-8c for guix-patches@gnu.org; Tue, 02 May 2017 06:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5Ulq-0002Gg-F6 for guix-patches@gnu.org; Tue, 02 May 2017 06:11:02 -0400 Subject: bug#26559: [PATCH] build: emacs: Install only a subset of files. Resent-Message-ID: From: Alex Kost References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> <87shl09pyg.fsf@gmail.com> Date: Tue, 02 May 2017 13:10:03 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 26 Apr 2017 19:50:56 +0530") Message-ID: <871ss736ys.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 26559@debbugs.gnu.org Arun Isaac (2017-04-26 19:50 +0530) wrote: > In the new patchset, I have cleaned up and removed some of the regexps, > as you suggested. I have also rewritten the logic using `find-files' > rather than with `ftw'. Great, thanks! >> Note, however, that 'move-doc' procedure should be adjusted to find >> info in "doc" subdir (for "doc/*.info$" regex). > > I don't think the `move-doc' phase needs to be changed. It finds .info > files with `find-files' which is recursive. Oh, right. >> It doesn't look right that these regexps are duplicated in 2 places. >> I'm not very familiar with build systems, but what if the >> 'include'/'exclude' arguments of 'install' procedure would simply be >> empty lists? I think it wouldn't do harm if you leave these regexps >> only in 'emacs-build' procedure or would it? > > I am not too familiar with build systems, but I think the > include/exclude arguments need to be duplicated in two places. For > example, look at arguments #:strip-flags and #:strip-directories in the > `strip' phase of the gnu-build-system. Even there, the default values of > the arguments are repeated in two places. Hm, ok, although I still think that these arguments are not needed to be duplicated in 'install' procedure, but I'm not the one to judge about it. >> I think it would be too much work. I quickly looked at the emacs >> packages, and I believe that only slime, auctex and yasnippet need to be >> adjusted to include non-standard files. Of course, there may be other >> packages that I'm not aware of, but they can be fixed later. > > I've provided patches for emacs-slime and emacs-auctex packages as > well. I believe I got all the required files, but please check. I personally don't use these packages, but I think they should be OK now, thank you! > As it stands, emacs-yasnippet does not seem to need any changes. But, I > think the package is already broken. It needs a snippets directory > pulled from a git submodule. Oh, right; last time I checked "yasnippet" (several years ago) this "snippets" directory was a part of the repo. > And, even the current package does not pull > this submodule. So, I believe the yasnippet package is already > broken. But, I don't use yasnippet, and I'm not too sure. Yeah, you are probably right, without snippets, yasnippet is=E2=80=A6 well, let's say limited. But let's leave this problem for those who use yasnippet :-) Thank you for this work! I hope someone else will look at this thread and will say "OK". As for me, I don't have any further comments and I think it is ready to be committed. In the worst case there would be a couple of broken emacs packages but they could be easily fixed. --=20 Alex