From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 26875@debbugs.gnu.org
Subject: bug#26875: [v2] system: grub: Expose GRUB's interactive interface settings.
Date: Sat, 13 May 2017 15:51:27 +0200 [thread overview]
Message-ID: <871srs50gw.fsf@gnu.org> (raw)
In-Reply-To: <171600ab2ba65d5e2c4f730d7c1ca8aae40aa4ff.1494652860.git.leo@famulari.name> (Leo Famulari's message of "Sat, 13 May 2017 01:21:02 -0400")
Hi Leo,
Leo Famulari <leo@famulari.name> skribis:
> * gnu/system/grub.scm (<grub-configuration>): Add new fields
> terminal-outputs, terminal-inputs, serial-unit, and serial-speed.
> (grub-setup-io, setup-gfxterm): New procedures.
> * doc/guix.texi (GRUB Configuration): Document the new fields.
Overall LGTM. Nice to see it taking shape!
Some minor comments and suggestions:
> +@item @code{terminal-outputs} (default: @code{'gfxterm})
> +The output terminals used for the GRUB boot menu, as a list of symbols.
> +These values are accepted: console, serial, serial_@{0-3@}, gfxterm,
> +vga_text, mda_text, morse, spkmodem
Please use @code for the possible, add a final period, and a
cross-reference to the relevant part of the GRUB manual with
“(@pxref{…})” if possible.
> +@item @code{terminal-inputs} (default: @code{'()})
> +The input terminals used for the GRUB boot menu, as a list of symbols.
> +The default is the native platform terminal as determined by GRUB at
> +run-time. These values are accepted: console, serial, serial_@{0-3@},
> +at_keyboard, usb_keyboard.
> +
> +@item @code{serial-unit} (default: @code{#f})
> +The serial unit used by GRUB, as an integer from 0 to 3. The default
> +value is chosen by GRUB at run-time; currently GRUB chooses 0, which
> +corresponds to COM1.
Likewise.
> +@item @code{serial-speed} (default: @code{#f})
> +The speed of the serial interface, as an integer. The default value is
> +chosen by GRUB at run-time; currently GRUB chooses 9600bps.
9,600@tie{}bps. :-)
Apart from that, as long as “make check-system TESTS=basic” and similar
pass, that’s all good for me!
Mathieu: is it OK to apply this before the patch series on non-GRUB
bootloaders?
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-05-13 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 7:36 bug#26875: Non-graphical (and other types) of GRUB interfaces Leo Famulari
2017-05-11 7:46 ` ng0
2017-05-13 5:15 ` Leo Famulari
2017-05-13 5:21 ` bug#26875: [v2] system: grub: Expose GRUB's interactive interface settings Leo Famulari
2017-05-13 13:51 ` Ludovic Courtès [this message]
2017-05-13 16:40 ` Leo Famulari
2017-05-14 7:38 ` Mathieu Othacehe
2017-05-14 18:17 ` Leo Famulari
2017-05-15 9:36 ` bug#26875: Non-graphical (and other types) of GRUB interfaces Brendan Tildesley
2017-05-15 18:04 ` Leo Famulari
2017-05-15 20:25 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871srs50gw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26875@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.