bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images.

[ludo@gnu.org (Ludovic Courtès)]

Marius Bakke <mbakke@fastmail.com> skribis:

> Here is a start on UEFI documentation update. Not sure if it's okay to
> hijack the lightweight desktop template, or if it's better to have an
> example closer to the (GRUB Configuration) section.

I think it’s OK.

> From 9db5b8acb017b8f283d36d09835f947879be4e30 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Thu, 18 May 2017 19:24:36 +0200
> Subject: [PATCH] doc: Update GRUB EFI instructions.
>
> * doc/guix.texi (USB Stick Installation): Mention UEFI.
> (Preparing for Installation): Add note about EFI System Partition.
> (Proceeding with the Installation): Mention the GRUB-EFI package.
> (GRUB Configuration): Likewise.
> (Using the Configuration System): Hijack lightweight desktop to include UEFI.
> * gnu/system/examples/lightweight-desktop.tmpl: Adjust native EFI configuration.

Great!  Minor suggestions:

> +If you instead wish to use EFI-based grub, a FAT32 EFI System Partition
> +is required.  This partition should be mounted at @file{/boot/efi} and
> +must have the @dfn{esp} flag set.  E.g. for @command{parted}:

I would change this paragraph like this

--8<---------------cut here---------------start------------->8---
@cindex EFI, installation
@cindex UEFI, installation
@cindex ESP, EFI system partition
If you instead wish to use EFI-based GRUB, a FAT32 @dfn{EFI System Partition}
(ESP) is required.  This partition should be mounted at @file{/boot/efi} and
must have the @code{esp} flag set.  E.g., for @command{parted}:
--8<---------------cut here---------------end--------------->8---

>  @item @code{grub} (default: @code{grub})
> -The GRUB package to use.
> +The GRUB package to use.  Currently either @code{grub} or @code{grub-efi}.

Maybe:

--8<---------------cut here---------------start------------->8---
@cindex EFI, bootloader
@cindex UEFI, bootloader
@cindex BIOS, bootloader
The GRUB package to use.  Currently either @code{grub}, for ``legacy''
x86 BIOS systems, or @code{grub-efi}, for modern systems using the
@dfn{Unified Extensible Firmware Interface} (UEFI).
--8<---------------cut here---------------end--------------->8---

>    ;; Assuming /dev/sdX is the target hard disk, and "my-root"
>    ;; is the label of the target root file system.
> -  (bootloader (grub-configuration (device "/dev/sdX")))
> -
> -  (file-systems (cons (file-system
> -                        (device "my-root")
> -                        (title 'label)
> -                        (mount-point "/")
> -                        (type "ext4"))
> -                      %base-file-systems))
> +  (bootloader (grub-configuration (grub grub-efi)
> +                                  (device "/dev/sdX")))

In the comment could you add that this is for a UEFI/EFI system?

Thank you!

Ludo’.