From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPZj0-0006qo-6Y for guix-patches@gnu.org; Mon, 26 Jun 2017 15:31:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPZiw-00056d-Vf for guix-patches@gnu.org; Mon, 26 Jun 2017 15:31:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36808) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPZiw-00056Z-Qy for guix-patches@gnu.org; Mon, 26 Jun 2017 15:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dPZiw-0008Mn-Hh for guix-patches@gnu.org; Mon, 26 Jun 2017 15:31:02 -0400 Subject: [bug#27344] [PATCH v2 06/12] gnu: Add freehdl. Resent-Message-ID: References: <20170622191005.25422-1-theodoros.for@openmailbox.org> <20170622191005.25422-6-theodoros.for@openmailbox.org> <20170624091837.4097c371@scratchpost.org> From: Theodoros Foradis Message-ID: <871sq6r3t2.fsf@openmailbox.org> In-reply-to: <20170624091837.4097c371@scratchpost.org> Date: Mon, 26 Jun 2017 21:40:09 +0300 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 27344@debbugs.gnu.org Hello again, > >> + (add-before 'configure 'patch-pkg-config >> + (lambda _ >> + (substitute* "freehdl/freehdl-config" >> + (("pkg-config") (which "pkg-config")) >> + (("cat") (which "cat"))) >> + #t)) > > freehdl-config is installed, but it uses a path to pkg-config which is from a native-input (so it will not be retained). > > Does this ever work again after removing pkg-config from your profile and then doing "guix gc" ? I doubt it... > >> + (add-after 'configure 'patch-freehdl-pc >> + (lambda _ >> + (substitute* "freehdl.pc" >> + (("=g\\+\\+") (string-append "=" (which "g++"))) >> + (("=libtool") (string-append "=" (which "libtool")))) >> + #t)) > > Same here... > >> + (add-after 'install-scripts 'make-wrapper >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out"))) >> + (wrap-program (string-append out "/bin/freehdl-config") >> + `("PKG_CONFIG_PATH" ":" prefix (,(string-append out "/lib/pkgconfig"))))) > > >> + #t))))) >> + (inputs >> + `(("perl" ,perl))) >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("libtool" ,libtool))) > I looked again into the issue. I would like to note that the same problem applies to qucs and qucs-s. They both need a native libtool for cross-compiling, and one for the final package to reference. I have to make some changes in other references in qucs, qucs-s and asco as well, but those are not conflicting with native inputs I think. Namely cp, and sed. On the topic on how could the issue be resolved, how is it determined which package will be in PATH if the same package is included as both native and non-native input under different names? Regards, -- Theodoros Foradis