From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLOpm-00031A-5H for guix-patches@gnu.org; Sun, 03 Dec 2017 02:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLOpj-0002OM-2v for guix-patches@gnu.org; Sun, 03 Dec 2017 02:37:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLOpi-0002OI-Vu for guix-patches@gnu.org; Sun, 03 Dec 2017 02:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLOpi-00075z-PM for guix-patches@gnu.org; Sun, 03 Dec 2017 02:37:02 -0500 Subject: [bug#29536] [PATCH] gnu: Add cava. Resent-Message-ID: From: Oleg Pykhalov References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> Date: Sun, 03 Dec 2017 10:16:18 +0300 In-Reply-To: <20171202220708.cg6xnqca7ovul5ng@abyayala> (ng0@n0.is's message of "Sat, 2 Dec 2017 22:07:08 +0000") Message-ID: <871skcwabh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 29536@debbugs.gnu.org --=-=-= Content-Type: text/plain Hello ng0, ng0 writes: > which patch would someone review? Aren't they supposed to be one patch? > We don't have cava (as you are obviously adding it) and the 2nd patch > makes a change to cava. > We try to logically group patches, and this is a case where having it > in one patch makes sense, when a new package is getting added. [...] Sorry for that. The second patch are just minor things (indent and remove missleading comment). It expected to be squashed as patch's message says. I also think about adding an example of configuration from origin tarball as I did https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29535 cava unlike cli-visualizer creates a configuration file for the first time, but it's empty and useless without example or documentation. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlojpMIACgkQckbhHGm3 lWmYXhAAw17brd8kwUC/xTs0sil5qtkxkbGjFtx7VkTey1ekXYLQ2QNeY5xjFy1n nCothcFCOocQZBMlWOoXDjD8EptW4PQ160oRBQdCpplobP6/eBLL45DJE0fDL/OG t+41VQb++lBl9UB3Q1WBgz1Nv/QY4sAis+Q9yNWkjrPXo2uy5ujGkhb1BqJ91Dvt Ub0WDWW/KCQxSa3D0N6C1ibZOJ0HDWnGWTbQWkO6bgHVjlTuHU63i3YsTevbvIKY bfAONOlNFm1WNP5y0USE5kr4ndA6fKUZKsjzcAFrqUVp2vvMuXJ8ciUBQvEqBjne D0LyI+r7A9mJoYcCEBaJCfbKY2+y1KN3JzrRUm6UCEMS9YtOhkU+t1DOne4Gi6OQ NwEEbKjhQMl8mELgBK8AjzC7Ae4twytLF13NtuJIxsvVnhHvN6MFpMpqJHjyIMNy o1YHPRodJmBjJfyREYCxcSSft745qNhkIVCZ/Uz4FX2nFDLWyyYI5HgUouGQqX0G JcN1uF7EptlEwwNjUSWDs6V50hfAasjyTx7EZ1w33ppcuet0WNkgkM7Wc+4dbu4G 7WuTQSXlrhUGv5tztl97981f+ZXOoFyT+iSku8XZom/8RQQG5Od+dj5S9VJHanio f/sNsoL/cEJl5iiWOOsqSwgr0VpK0XBAJpIU64GoWyYhtDFe2t4= =CKsT -----END PGP SIGNATURE----- --=-=-=--