From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/03: gnu: Add QD.
Date: Sat, 03 Feb 2018 22:55:56 -0500
Message-ID: <871si1z9v7.fsf@netris.org>
References: <20180202143848.26172.43250@vcs0.savannah.gnu.org>
	<20180202143849.080E924648@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eiBQ5-0007hy-5Y
	for guix-devel@gnu.org; Sat, 03 Feb 2018 22:56:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eiBQ2-0007G0-0v
	for guix-devel@gnu.org; Sat, 03 Feb 2018 22:56:45 -0500
Received: from world.peace.net ([50.252.239.5]:57330)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mhw@netris.org>) id 1eiBQ1-0007EE-Sb
	for guix-devel@gnu.org; Sat, 03 Feb 2018 22:56:41 -0500
In-Reply-To: <20180202143849.080E924648@vcs0.savannah.gnu.org> (Eric Bavier's
	message of "Fri, 2 Feb 2018 09:38:48 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: guix-devel@gnu.org

Hi Eric,

ericbavier@centurylink.net (Eric Bavier) writes:
> bavier pushed a commit to branch master
> in repository guix.
>
> commit cbc084e1a7c25d1c8944bcb20a989f795acdb096
> Author: Eric Bavier <bavier@cray.com>
> Date:   Wed Jan 31 13:55:37 2018 -0600
>
>     gnu: Add QD.
[...]
> +(define-public qd
> +  (package
> +    (name "qd")
> +    (version "2.3.18")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://crd.lbl.gov/~dhbailey/mpdist/qd-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0vkihcj9fyv2cycq8515713gbs3yskhmivy8bznvx72i6ddnn2c1"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("gfortran" ,gfortran)))
> +    (arguments
> +     `(#:configure-flags `("--disable-enable_fma" ;weird :/

"weird :/" is not a very useful comment.  Can you change it to explain
why you added this flag?  It seems unfortunate to disable fused
multiply-add for this kind of library.

      Mark