From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMFJ8-0001zm-P6 for guix-patches@gnu.org; Fri, 25 May 2018 12:12:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMFI4-0002Vw-N4 for guix-patches@gnu.org; Fri, 25 May 2018 12:11:10 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40737) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMFI4-0002VI-Cb for guix-patches@gnu.org; Fri, 25 May 2018 12:10:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMFI2-0000Lr-8s for guix-patches@gnu.org; Fri, 25 May 2018 12:10:04 -0400 Subject: [bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180522084332.30409-1-go.wigust@gmail.com> <87603ezfqn.fsf@gnu.org> <87d0xkxbak.fsf@gmail.com> Date: Fri, 25 May 2018 18:08:35 +0200 In-Reply-To: <87d0xkxbak.fsf@gmail.com> (Oleg Pykhalov's message of "Fri, 25 May 2018 13:46:43 +0300") Message-ID: <871sdz3egs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 31548@debbugs.gnu.org Oleg Pykhalov skribis: > Hello Ludovic, > > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Oleg Pykhalov skribis: >> >>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable. >> >> [...] >> >>> +(define-public sbcl-stumpwm-checkout >>> + (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947")) >>> + (package >>> + (inherit sbcl-stumpwm) >>> + (version (git-version (package-version sbcl-stumpwm) "1" commit)) >> >> Could you explain the rationale and write that as a comment? :-) >> >> As you know we currently avoid packaging unreleased versions unless we >> have a good reason to do so (info "(guix) Version Numbers"). > > The reason I want to be it in a Guix package collection is StumpWM > release version (not a release candidate) was published 1 year ago and > since this date there are 250 commits in master branch. > > I was using StumpWM builded manually with Quicklisp, but then I switched > to Guix package, because I don't want to build StumpWM manually, but I > found that StumpWM command =E2=80=98toggle-always-on-top=E2=80=99 is miss= ing and StumpWM > contrib modules failed to build. > > It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib > modules with some dependencies builded with Quicklisp. :-) E.g.: OK, that sounds reasonable. In that case, I=E2=80=99d suggest changing the =E2=80=9Cname=E2=80=9D field= to =E2=80=9Cstumpwm-next=E2=80=9D as we did a few times in the past, so that by default, people still get the official release. That and a comment summarizing what you wrote above and you can go ahead! Thanks, Ludo=E2=80=99.