From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 02/02: services: Add Gitolite. Date: Sat, 29 Sep 2018 21:45:43 -0400 Message-ID: <871s9b69mg.fsf@netris.org> References: <20180928200104.10056.60968@vcs0.savannah.gnu.org> <20180928200105.E0B4F20476@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6QoF-0004gp-8x for guix-devel@gnu.org; Sat, 29 Sep 2018 21:46:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6QoB-0002zu-9x for guix-devel@gnu.org; Sat, 29 Sep 2018 21:46:11 -0400 Received: from world.peace.net ([64.112.178.59]:52190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g6QoB-0002wj-65 for guix-devel@gnu.org; Sat, 29 Sep 2018 21:46:07 -0400 In-Reply-To: <20180928200105.E0B4F20476@vcs0.savannah.gnu.org> (Christopher Baines's message of "Fri, 28 Sep 2018 16:01:05 -0400 (EDT)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Hi Christopher, mail@cbaines.net (Christopher Baines) writes: > cbaines pushed a commit to branch master > in repository guix. > > commit 258a6d944ed891fa92fa87a16731e5dfe0bac477 > Author: Christopher Baines > Date: Fri Jul 13 20:39:46 2018 +0100 > > services: Add Gitolite. > > * gnu/services/version-control.scm (, > ): New record types. > (gitolite-accounts, gitolite-activation): New procedures. > (gitolite-service-type): New variables. > * gnu/tests/version-control.scm (%gitolite-test-admin-keypair, %gitolite-os, > %test-gitolite): New variables. > (run-gitolite-test): New procedure. > * doc/guix.texi (Version Control): Document the gitolite service. This commit has a flaw which broke evaluations on Hydra, so I reverted it for now. > +(define-gexp-compiler (gitolite-rc-file-compiler > + (file ) system target) > + (match file > + (($ umask git-config-keys roles enable) > + (apply text-file* "gitolite.rc" > + `("%RC = (\n" > + " UMASK => " ,(format #f "~4,'0o" umask) ",\n" The problem is here, in the call to 'format'. Guile has two variants of the 'format' procedure: a very simple one which is always available (also known as 'simple-format'), and a much more complex and featureful variant in (ice-9 format). In the code above, you are assuming that (ice-9 format) has been loaded, but you have not arranged for that to happen. During the Hydra evaluation, this led to the following error: --8<---------------cut here---------------start------------->8--- 0 (simple-format #f "~4,'0o" 63) ERROR: In procedure simple-format: In procedure simple-format: FORMAT: Unsupported format option ~4 - use (ice-9 format) instead --8<---------------cut here---------------end--------------->8--- I guess that the fix will involve 'with-imported-modules'. Could you take a look? Mark