From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: Merging =?utf-8?Q?=E2=80=98wip-newt-installer=E2=80=99?= in
	master?
Date: Sat, 24 Nov 2018 12:57:30 +0900
Message-ID: <871s7bm8k5.fsf@gmail.com>
References: <87lg6sejwa.fsf@gmail.com> <87wopd88hq.fsf@gmail.com>
	<877ehcsocq.fsf@gnu.org> <87bm6oxsyf.fsf@gmail.com>
	<cucy39rq19w.fsf@lprndn.info> <87a7m7yhu5.fsf@gmail.com>
	<cuc1s7jiy3r.fsf@lprndn.info> <878t1rygfu.fsf@gmail.com>
	<cuc8t1r923g.fsf@lprndn.info> <877ehbydmz.fsf@gmail.com>
	<87sgzykmyx.fsf@gnu.org> <877eh9245u.fsf@gmail.com>
	<87efbgx0p0.fsf@gnu.org> <87sgzw5ylb.fsf@gmail.com>
	<87zhu1cw4p.fsf_-_@gnu.org> <875zwp17od.fsf@gmail.com>
	<87lg5j6h00.fsf@gnu.org> <87pnuv26jv.fsf@gmail.com>
	<87efbb4xpt.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1gQP71-0003m0-Fe
	for guix-devel@gnu.org; Fri, 23 Nov 2018 23:00:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1gQP4d-0005Qc-89
	for guix-devel@gnu.org; Fri, 23 Nov 2018 22:57:42 -0500
In-reply-to: <87efbb4xpt.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Hi,

> Heheh.  Another option would be to pass the locale name to the installer
> right from (gnu system install).  That way, if people want to build an
> image with a different default locale, they can do it.
>
> Fundamentally though, it=E2=80=99s the installer=E2=80=99s job to offer a=
 choice of
> languages early on, which it does pretty well already!

Ok you convinced me, I'll just call 'setlocale' at installer start, this
is less dirty.

> I think we want to distribute (gnu installer =E2=80=A6) modules, just not=
 build
> them.  The thing is, they should be =E2=80=9Cbuild-side only=E2=80=9D mod=
ules, and thus
> we don=E2=80=99t need to compile them; it=E2=80=99s like (guix man-db), f=
or instance.
>
> So I think gnu/installer/*.scm could go in the *system-modules* node as
> #:extra-files.
>
> Does that make sense?

Yes I understand now. The idea of using only build code is quite nice,
it simplifies a lot of things. So now, (gnu install) is the tip of the
iceberg and everything under gnu/installer/ is build side code (and set
as #:extra-files of *system-modules* in (guix self)). I pushed
a new commit on the branch to fix all of this, it seems ok now.

Thanks for your help,

Mathieu