From mboxrd@z Thu Jan 1 00:00:00 1970 From: Meiyo Peng Subject: Re: Plan for fish shell in Guix. Date: Mon, 21 Jan 2019 16:32:11 +0800 Message-ID: <871s562yyc.fsf@disroot.org> References: <87imz0x1i3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:43794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glV0P-0003bg-Q8 for guix-devel@gnu.org; Mon, 21 Jan 2019 03:32:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glV0P-0000vL-2m for guix-devel@gnu.org; Mon, 21 Jan 2019 03:32:29 -0500 Received: from knopi.disroot.org ([178.21.23.139]:55388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glV0N-0000mL-1J for guix-devel@gnu.org; Mon, 21 Jan 2019 03:32:27 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 15F5523FE8 for ; Mon, 21 Jan 2019 09:32:16 +0100 (CET) Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IzCz2naFmowu for ; Mon, 21 Jan 2019 09:32:14 +0100 (CET) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 58c26113 for ; Mon, 21 Jan 2019 08:32:11 +0000 (UTC) In-reply-to: <87imz0x1i3.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Hello everyone, Thank you for your patience. I investigated the problem and chose to parse /etc/profile from fish rather than generate separate configuration files for fish. I think this will make the Guix project easier to maintain in the future. I looked NixOS's solution. They choose this approach too, but their patch is more complex. I implemented my patch in a minimalistic manner. The patch has been sent to guix-patches@gnu.org: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34153 I set fish as my login shell and every thing is working well. Please try the patch and report bugs if you are interested. Thanks. -- Meiyo Peng https://www.pengmeiyu.com/