Hello,

Thank you for the review!

Ludovic Courtès <ludo@gnu.org> writes:

> Apparently you also tried using ffmpeg 2.8, but that didn’t work
> either?

It builds with FFmpeg 2.8, but a StepMania developer told me there was
no guarantee it wouldn't create runtime crashes. They apparently spend
quite some time to find a FFmpeg release that suits them, and use it for
a couple of years.

> Do you have an idea how different their own ffmpeg variant is?

Their variant is older (2.1.3), with some specific build flags. That is
all I can say.

> Could you move to video.scm, inherit from ‘ffmpeg’, and arrange to
> reduce duplication as much as possible?

But then, I have to make it public, and that would pollute namespace,
wouldn't it?

> (Even better would be to avoid it altogether but I’m assuming it won’t
> be that simple…)

There's a build flag to ignore FFmpeg altogether. I believe this would
disable playing background videos. It may be a bit opinionated for
a distributed package.

IMO, the safest way to go it to provide the FFmpeg the package expects.

I'm sending an updated patch. WDYT?

Regards,

-- 
Nicolas Goaziou