From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: custom kernel config
Date: Wed, 01 May 2019 16:15:56 +0200
Message-ID: <871s1igt0j.fsf@gnu.org>
References: <20190401180434.GF21029@macbook41> <87wokb1pg1.fsf@gmail.com>
	<20190403190404.GB1203@macbook41>
	<871s2iuavs.fsf@mimimi.i-did-not-set--mail-host-address--so-tickle-me>
	<20190403202758.GC1203@macbook41> <87zhp6rwfz.fsf@gmail.com>
	<20190407143648.GA1337@macbook41> <87zhp0v9aj.fsf@gnu.org>
	<87pnp2msfb.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:48804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1hLq1g-0002I0-Eh
	for guix-devel@gnu.org; Wed, 01 May 2019 10:16:03 -0400
In-Reply-To: <87pnp2msfb.fsf@netris.org> (Mark H. Weaver's message of "Wed, 01
	May 2019 05:31:41 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hello,

Mark H Weaver <mhw@netris.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:

[...]

>>> (define-public linux-libre-E2140
>>>   (let ((base
>>>           ((@@ (gnu packages linux) make-linux-libre)
>>>            (@@ (gnu packages linux) %linux-libre-version)
>>>            (@@ (gnu packages linux) %linux-libre-hash)
>>>            '("x86_64-linux")
>>>            #:extra-version "E2140"
>>>            #:patches (@@ (gnu packages linux) %linux-libre-5.0-patches)=
)))
>>
>> Could we make all =E2=80=98make-linux-libre=E2=80=99 public to avoid the=
 @@ there?
>> Otherwise it=E2=80=99s a bit scary, and not something we could recommend=
 since
>> we=E2=80=99re accessing private variables.
>
> I'm sorry that I didn't see this message sooner, but FWIW: I would
> prefer not to export 'make-linux-libre', because I have found it to be a
> poorly designed interface in need of replacement, and it would be good
> to avoid having to maintain it going forward.

Yeah, I wasn=E2=80=99t sure.  Do you have specific issues in mind that you =
think
should be addressed?

Anyway for the post, Efraim could perhaps write:

  (define make-linux-libre
    ;; XXX: Access the internal =E2=80=98make-linux-libre=E2=80=99 procedur=
e, which is
    ;; private until its interface has stabilized.  Stay tuned!
    (@@ (gnu packages linux) make-linux-libre))

Thanks,
Ludo=E2=80=99.