From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:41140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMumm-00046w-9v
	for guix-patches@gnu.org; Sat, 04 May 2019 09:33:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMuml-0002np-Ex
	for guix-patches@gnu.org; Sat, 04 May 2019 09:33:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:37046)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hMuml-0002nc-2c
	for guix-patches@gnu.org; Sat, 04 May 2019 09:33:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMumk-0005ag-VJ
	for guix-patches@gnu.org; Sat, 04 May 2019 09:33:02 -0400
Subject: [bug#35545] [PATCH 08/17] gnu: Add java-openjfx-base.
Resent-Message-ID: <handler.35545.B35545.155697675621453@debbugs.gnu.org>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-8-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190503130134.24788-8-julien@lepiller.eu>
Date: Sat, 04 May 2019 13:46:06 +0200
Message-ID: <871s1eh281.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35545@debbugs.gnu.org


Julien Lepiller <julien@lepiller.eu> writes:

> * gnu/packages/java.scm (java-openjfx-base): New variable.
[=E2=80=A6]
> +       #:source-dir "modules/base/src/main/java:modules/base/src/main/ja=
va8:modules/base/src/main/version-info"

This line is very long.  Could you use (string-join =E2=80=A6) on a list of
directories instead?

> +       #:test-dir "modules/base/src/test"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'remove-empty-file

=E2=80=9Cfiles=E2=80=9D, because it=E2=80=99s more than one?

> +    (description "OpenJFX is a free, next generation client application

Please remove =E2=80=9Cfree=E2=80=9D and =E2=80=9Cnext generation=E2=80=9D.

--=20
Ricardo