From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRMbj-0002Rn-P4 for guix-patches@gnu.org; Thu, 16 May 2019 16:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRMbi-00041B-Rm for guix-patches@gnu.org; Thu, 16 May 2019 16:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRMbi-00040k-P7 for guix-patches@gnu.org; Thu, 16 May 2019 16:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRMbi-0002Rk-J9 for guix-patches@gnu.org; Thu, 16 May 2019 16:04:02 -0400 Subject: [bug#35720] [PATCH] gnu: Add chocolate-doom. Resent-Message-ID: References: <20190513194251.GA18548@sdf.lonestar.org> From: Christopher Lemmer Webber In-reply-to: <20190513194251.GA18548@sdf.lonestar.org> Date: Thu, 16 May 2019 16:03:43 -0400 Message-ID: <871s0ygo9s.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35720@debbugs.gnu.org Jakob L. Kreuze writes: > Patch adding a package for Chocolate Doom, which I felt was appropriate > as both Odamex and GZDoom are packaged in Guix. > > Regards, > Jakob L. Kreuze Hey Jakob! Your patch looks good in general, though I haven't had a chance to try building and running it yet. Maybe just a couple of things: - I think it would be "New variable" rather than "New variables" in the commit message. Not that this is a big deal, and I could fix it. - It would be good to test if it can run with freedoom (a libre doom content replacement for doom that's functionaly similar). My guess is that the one change would need to be adjusting where the default searched WAD path is. freedoom and gzdoom both add a reference to /share/games/doom so I'm guessing that's how it's found. However I'm not positive about that. Looking good though in general!