From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXt4q-0007jQ-Ff for guix-patches@gnu.org; Mon, 03 Jun 2019 15:57:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXt4p-0003yF-4l for guix-patches@gnu.org; Mon, 03 Jun 2019 15:57:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57885) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXt4o-0003xW-OY for guix-patches@gnu.org; Mon, 03 Jun 2019 15:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXt4o-0000R4-Ks for guix-patches@gnu.org; Mon, 03 Jun 2019 15:57:02 -0400 Subject: [bug#35935] [PATCH] guix: import: simplify recursive import Resent-Message-ID: From: Oleg Pykhalov References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org> Date: Mon, 03 Jun 2019 22:56:21 +0300 In-Reply-To: (Robert Vollmert's message of "Sun, 2 Jun 2019 22:23:56 +0200") Message-ID: <871s0asasa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Robert Vollmert Cc: 35935@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Robert, Robert Vollmert writes: [=E2=80=A6] >> I think Oleg worked on this part before; Oleg, could you comment >> and/or apply? >>=20 >> =E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be test= ing this procedure, >> perhaps that=E2=80=99s something we should fix eventually. > > Agreed. It does seem to be covered somewhat by tests/gem.scm. > I also tested it a bit by hand, with some haskell packages. True, =E2=80=98tests/gem.scm=E2=80=99 file tests =E2=80=98recursive-import= =E2=80=99 procedure by invoking =E2=80=98gem-recursive-import=E2=80=99. I think this test is good= enough for our purpose - use =E2=80=98recursive-import=E2=80=99 in other package impor= ters and make sure it works. Thoughts? I also added a copyright line if you don't mind: ;;; Copyright =C2=A9 2019 Robert Vollmert Is it OK, Robert? I tested manually with =E2=80=98gem=E2=80=99 and =E2=80= =98elpa=E2=80=99 recursive importers and ready to push :-) Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlz1e2UACgkQFn+OpQAa +pzY1w/+Kdon/5c5DEmX+HjdDSBc0TUm0iiJefO6k9YOHyCQG6SlBa0L47J309t0 irg2ViUffM5vjbkCaPwXeOKxTsENpOqGKKduyU7LXNBRFzXi69Ky2zbTW4rFX/3N gfnpTVgq6Myof0XIa1qLFmyWujZcMJ16JCxd68OYQDhTEcS9WE8bQZlGStNgRXwC Uzj0wRSSgG0dyeqk045BYjL/GEVbhw8QTz8CtiFgutIMRtcF7xNntNjDSZKJpjw9 lAbJLACkHP6qyBWa8TmwLaeIIxnUqhNo90Me3orWEJOsd/gfVsMtPnZ3HZNPW251 zWU0kw7kPZW+bCX0R56Qr19+oXcthYY7UZ+V+ChlgSCb06COzqCaURod5f/oXeFQ IOJSg3MY+GyYWmP3riH5vGQi9zQT2zHF3E18P7YokzsZKSaPuwVUPBbCV8kMM2n9 F4cRPqM6AOK1RouTmOI5GyRpJY6i8shaBU5zO/nQLrfCl3KVsBv24jwhpZY+h4Tf aM9Llyu771lGf+2uBW+e6LnoYt8NLrX/QUAsRfJ0Gf+moZVJ4A/SL+dvcAx558y3 qLeSfiupcNVkzhy8xeE2XrPrXiDx0sVV2NL+DaCmfPFhKXDczeRsd6WCdQlNDJxm ADn8mELirdktFebJMdo6kUR+QcIFNJOr6MdswiMHZ2jgkwaqlYw= =cPSA -----END PGP SIGNATURE----- --=-=-=--