From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:55958)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizhi-00005b-Tm
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:15:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizhg-0004AC-1S
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:15:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41629)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hizhe-00048i-2p
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:15:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hizhd-0004lh-TY
 for guix-patches@gnu.org; Thu, 04 Jul 2019 07:15:01 -0400
Subject: [bug#36469] [PATCH 1/2] pack: 'docker' backend records the profile's
 search paths.
Resent-Message-ID: <handler.36469.B36469.156223885218256@debbugs.gnu.org>
References: <20190702083731.10354-1-ludo@gnu.org>
 <20190702085601.10865-1-ludo@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
Message-ID: <871rz6t5ll.fsf@elephly.net>
In-reply-to: <20190702085601.10865-1-ludo@gnu.org>
Date: Thu, 04 Jul 2019 13:13:59 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludovic.courtes@inria.fr>
Cc: 36469@debbugs.gnu.org


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> * gnu/tests/docker.scm (run-docker-test)["Load docker image and run it"]:
> Add example that expects (json) to be available.

This message here is clearer than the actual test.  In the test all that
JSON stuff is really only there to test that (json) is available, right?

Maybe it=E2=80=99s worth adding a comment to the test itself.

> diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
> index c90b777222..bb6a8cda1a 100644
> --- a/guix/scripts/pack.scm
> +++ b/guix/scripts/pack.scm
> @@ -27,6 +27,7 @@
>    #:use-module (guix utils)
>    #:use-module (guix store)
>    #:use-module ((guix status) #:select (with-status-verbosity))
> +  #:use-module ((guix self) #:select (make-config.scm))
>    #:use-module (guix grafts)
>    #:autoload   (guix inferior) (inferior-package?)
>    #:use-module (guix monads)
> @@ -440,11 +441,24 @@ the image."
>    (define build
>      ;; Guile-JSON and Guile-Gcrypt are required by (guix docker).
>      (with-extensions (list guile-json guile-gcrypt)
> -      (with-imported-modules (source-module-closure '((guix docker)
> -                                                      (guix build store-=
copy))
> -                                                    #:select? not-config=
?)
> +      (with-imported-modules `(((guix config) =3D> ,(make-config.scm))
> +                               ,@(source-module-closure
> +                                  `((guix docker)
> +                                    (guix build store-copy)
> +                                    (guix profiles)
> +                                    (guix search-paths))
> +                                  #:select? not-config?))

Woah, that =E2=80=9C=3D>=E2=80=9D thing is to generate a module dynamically=
?  I hadn=E2=80=99t
seen this before.  Nifty!

The rest of this commit looks good to me.  Thanks for working on it!

--=20
Ricardo