From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47495) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmCEO-0001Fw-SW for guix-patches@gnu.org; Sat, 13 Jul 2019 03:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmCEM-0000I3-KJ for guix-patches@gnu.org; Sat, 13 Jul 2019 03:14:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmCEM-0000Hk-BE for guix-patches@gnu.org; Sat, 13 Jul 2019 03:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmCEM-0003jj-4Q for guix-patches@gnu.org; Sat, 13 Jul 2019 03:14:02 -0400 Subject: [bug#36628] [PATCH 1/2] gnu: pngcrush: fix typo in description Resent-Message-ID: References: <20190712214110.23718-1-arne_bab@web.de> <20190712214110.23718-2-arne_bab@web.de> <87ef2u521z.fsf@nckx> From: Arne Babenhauserheide In-reply-to: <87ef2u521z.fsf@nckx> Date: Sat, 13 Jul 2019 09:12:56 +0200 Message-ID: <871ryu8l1j.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 36628@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Arne, > > Arne Babenhauserheide wrote: >> * gnu/packages/image.scm (pngcrush): fix typo in description >> --- >> gnu/packages/image.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm >> index 511f5302b7..b465ff376e 100644 >> --- a/gnu/packages/image.scm >> +++ b/gnu/packages/image.scm >> @@ -250,7 +250,7 @@ APNG patch provides APNG support to libpng.") >> ("zlib" , zlib))) >> (home-page "https://pmt.sourceforge.io/pngcrush") >> (synopsis "Utility to compress PNG files") >> - (description "pngcrusqh is an optimizer for PNG (Portable >> Network Graphics) >> + (description "pngcrush is an optimizer for PNG (Portable Network >> Graphics) >> files. It can compress them as much as 40% losslessly.") >> (license license:zlib))) > > Thanks! I was going to quickly apply these two before sleepytimes but > noticed that your other patch changes the description (only) to begin > with a capital letter, while this one remains lowercase. Is that > deliberate? For the other one guix lint complained, here it did not (maybe because it started with exactly the package name?). That=E2=80=99s the only reason. > I also couldn't help myself and kept editing... What do you think of > the following? (It's still awfully short but that's another issue.) > > --- a/gnu/packages/image.scm > +++ b/gnu/packages/image.scm > @@ -250,8 +250,8 @@ APNG patch provides APNG support to libpng.") > ("zlib" , zlib))) > (home-page "https://pmt.sourceforge.io/pngcrush") > (synopsis "Utility to compress PNG files") > - (description "pngcrusqh is an optimizer for PNG (Portable Network > Graphics) > -files. It can compress them as much as 40% losslessly.") > + (description "Pngcrush optimizes @acronym{PNG, Portable Network > Graphics} > +images. It can losslessly compress files by as much as an additional > 40%.") > (license license:zlib))) That sounds better. I think the correct English is "compress losslessly" and not "losslessly compress", but aside from that it=E2=80=99s much more c= risp. I don=E2=80=99t think that being short is a problem, rather the opposite: if it=E2=80=99s easy to read and provides the information needed, short is often better. So go for it! :) Best wishes, Arne =2D- Unpolitisch sein hei=C3=9Ft politisch sein ohne es zu merken --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE801qEjXQSQPNItXAE++NRSQDw+sFAl0phHoACgkQE++NRSQD w+u+eA//TOmRoWs+SMkxgmjo0tHnuF3VXrE9bn3GFUU074iyujVvbC9665S4hYzN Lwl172OLC0sU58LRlNZ9sdkEnbsyf54ERjiXLo3wnydOvuZsAxc2Usq9FYswkSHW 6yUCllXak7B4qVfn8f9RUMj+w0pqHg9a/m33zUJrKaYb3rUPntulM/TrNLjFjPpZ WSKRMNdMaVhweH6k6KkoP5xbg0jefIUXXHZkAbFqldTEcZOYQtCakIBEg+dJOdn/ dnzu69wU1PUUAUHKiaSdjqzb9M1LWlXbP0/k4dW+f9QycpKLNhoi8qcwEwyr8qo4 o/O0KHVe1fc5ca25msZHHlR4smnYHOeQm0XBB6wCQIOvhXtdcrEoaI3eShEBTaRA fwGqb/QsHp1a5G5t5mca3v+B74Ox3Yya+sdj2wNNK5hksaGzq1To8gfRuCJyYP52 gKOqvGGdaXFvcOLw0FrtbzzEwDolS8X/QFs6fn+yM0xO8DA0t8RAeTtR4jdlSZCP 4uMyAdFNcuMTgwJ4bARO0H7JgseonhadAGT/mkM6CJYk+kflhEskW87bLXus/kxu Nqa/IA0kaAM3COYD3WBNdSvkHswCnCQMHkexpc2kfqOPQB3rLgCqaKB9drR9ZFx1 sRbTClqC5OOhIWfMtJF+/q4R41wOoqoq2ZnLgWKXo/I0LnQJ+qyIswQBAQgAHRYh BN0ovebZh1yrzkqLHdzPDbMLwQVIBQJdKYR6AAoJENzPDbMLwQVIQfgD/1j0CHuX KhWpYHBEA7hKxz7kw8U36L+MSuEMC4xd5Few395xjl+zrbeASniM08x8SPV0Fpc2 6iTyuYKI1R7LJsneKttzDxAUqDVk8J04lsorBFX6d1u0rsF62WTifYHKiF5oU9Sk DTIFGIky9CMdVKjLPAbMZdOuOuy7BkOzfBp0 =4+24 -----END PGP SIGNATURE----- --=-=-=--