From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#36375: [PATCH] Re: =?UTF-8?Q?=E2=80=98guix_?=
 =?UTF-8?Q?package=E2=80=99?= should lock the profile
Date: Fri, 08 Nov 2019 21:03:05 +0100
Message-ID: <871ruif85i.fsf@gnu.org>
References: <875zotn4c1.fsf@gnu.org>
 <20191025214451.284c3530@sybil.lepiller.eu> <87tv7wldwh.fsf@gnu.org>
 <20191026000806.7eb6342b@sybil.lepiller.eu> <87mud95e8p.fsf@gnu.org>
 <20191107221936.1ff9bed6@sybil.lepiller.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:38642)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTAUI-0001hd-SD
 for bug-guix@gnu.org; Fri, 08 Nov 2019 15:04:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTAUH-00085O-W6
 for bug-guix@gnu.org; Fri, 08 Nov 2019 15:04:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:38844)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iTAUH-00085K-Sh
 for bug-guix@gnu.org; Fri, 08 Nov 2019 15:04:05 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTAUE-0001Ei-EM
 for bug-guix@gnu.org; Fri, 08 Nov 2019 15:04:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.36375.B36375.15732433994697@debbugs.gnu.org>
In-Reply-To: <20191107221936.1ff9bed6@sybil.lepiller.eu> (Julien Lepiller's
 message of "Thu, 7 Nov 2019 22:19:36 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 36375@debbugs.gnu.org

Hello!

Julien Lepiller <julien@lepiller.eu> skribis:

> From 71a85b5a8aac6c0bd5a1a4e3b52e409b2112df7a Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Thu, 7 Nov 2019 21:50:54 +0100
> Subject: [PATCH 1/2] guix: Add file-locking with no wait.
>
> * guix/build/syscalls.scm (with-file-lock/no-wait): New procedure.
> (lock-file): Take a #:wait? key.

[...]

> From 50c792e155d1207127f10ff0c0360442b7736a64 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 25 Oct 2019 21:39:21 +0200
> Subject: [PATCH 2/2] guix: package: lock profiles when processing them.
>
> * guix/scripts/package.scm (process-actions): Get a per-profile lock to
> prevent concurrent actions on profiles.
> * tests/guix-package.sh: Add test.

LGTM!

I tested =E2=80=98with-file-lock=E2=80=99 on an NFSv3 mount, and =E2=80=98F=
_SETLKW=E2=80=99 is correctly
implemented, FWIW.

Thank you!

Ludo=E2=80=99.