all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Amin Bandali <bandali@gnu.org>
Cc: 38662@debbugs.gnu.org
Subject: [bug#38662] [PATCH] gnu: Add emacs-next.
Date: Fri, 20 Dec 2019 22:59:56 +0100	[thread overview]
Message-ID: <871rsypsir.fsf@gnu.org> (raw)
In-Reply-To: <20191218200419.28836-1-bandali@gnu.org> (Amin Bandali's message of "Wed, 18 Dec 2019 15:04:19 -0500")

Hi Amin,

Amin Bandali <bandali@gnu.org> skribis:

> Add `emacs-next' for building latest Emacs from git.
>
> * gnu/packages/emacs.scm (emacs-next): New variable.
> (emacs): make the autoload deletion snippet not fail when eshell/esh-groups.el
> does not exist.  This enables reuse of the entire snippet field of `emacs' for
> `emacs-next'.

Nice!  Please also mention the new patch file and add it to
gnu/local.mk.

It LGTM, but…

>               (snippet
> -              ;; Delete the bundled byte-compiled elisp files and
> -              ;; generated autoloads.
>                '(with-directory-excursion "lisp"
> +                 ;; Delete the bundled byte-compiled elisp files and generated
> +                 ;; autoloads.
>                   (for-each delete-file
>                             (append (find-files "." "\\.elc$")
>                                     (find-files "." "loaddefs\\.el$")
>                                     ;; This is the only "autoloads" file that
>                                     ;; does not have "*loaddefs.el" name.
> -                                   '("eshell/esh-groups.el")))
> +                                   (find-files "." "eshell/esh-groups\\.el$")))

This change causes a rebuild of ‘emacs’, ‘emacs-minimal’, and everything
that depends on them (1K+ packages.)  Can it be avoided somehow?

One solution would be to duplicate the snippet for now in ‘emacs-next’.

> --- /dev/null
> +++ b/gnu/packages/patches/emacs27-exec-path.patch

Please add a line or two at the top explaining what this patch does.

Could you send an updated patch?

Thanks!

Ludo’.

  parent reply	other threads:[~2019-12-20 22:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 20:04 [bug#38662] [PATCH] gnu: Add emacs-next Amin Bandali
2019-12-18 20:15 ` Amin Bandali
2019-12-19 13:38   ` Valentin Ignatev
2019-12-19 14:08     ` Valentin Ignatev
2019-12-19  2:28 ` Brett Gilio
2019-12-20 21:59 ` Ludovic Courtès [this message]
2019-12-22  6:15   ` Amin Bandali
2019-12-23 18:26     ` bug#38662: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rsypsir.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38662@debbugs.gnu.org \
    --cc=bandali@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.