From mboxrd@z Thu Jan 1 00:00:00 1970 From: mike.rosset@gmail.com Subject: Re: qtwenengine anybody? Date: Mon, 06 Jan 2020 16:27:43 -0800 Message-ID: <871rsccdq8.fsf@gmail.com> References: <87a77sqtdq.fsf@ambrevar.xyz> <87immgqryj.fsf@gmail.com> <871rt4qnp9.fsf@gmail.com> <87immgp582.fsf@gmail.com> <5955729d-ef57-ffb8-feb8-36a9f53658a2@crazy-compilers.com> <87d0clpbt6.fsf@gmail.com> <87y2v7e0g4.fsf@ambrevar.xyz> <87v9qb56gg.fsf@gmail.com> <87sglfotvj.fsf@ambrevar.xyz> <87o8w354m5.fsf@gmail.com> <87blrod2so.fsf@ambrevar.xyz> <878smsd2pe.fsf@ambrevar.xyz> <87mub7krlq.fsf@gmail.com> <87tv5e9acb.fsf@ambrevar.xyz> <87o8vmn6an.fsf@elephly.net> <87zhf2c5jy.fsf@gmail.com> <87lfql7k9w.fsf@elephly.net> <87d0bw2xtj.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34895) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iocit-0008Ar-V2 for guix-devel@gnu.org; Mon, 06 Jan 2020 19:27:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iocis-00063x-Ft for guix-devel@gnu.org; Mon, 06 Jan 2020 19:27:51 -0500 In-Reply-To: <87d0bw2xtj.fsf@devup.no> (Marius Bakke's message of "Mon, 06 Jan 2020 20:23:52 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org, GNU Guix maintainers Marius Bakke writes: > Ricardo Wurmus writes: > >> Hi Mike, >> >> thank you for your patient reply. >> >>> Ricardo Wurmus writes: >>> >>>> Does the code include DRM support, for example? Does it phone home? >>>> Can we see the patches that upstream applied to the Chromium sources? >>>> >>> >>> QtWebengine does not handle DRM at all. That is handled by a 3rd party >>> plugin called wildevine and would require guix to bundle that plugin. >>> Something I'm confident is not going to happen. As an added measure my >>> proposed qtwebengine declaration has pepper plugins disabled making it >>> impossible to load 3rd party plugins either way. >>> >>> see https://doc.qt.io/qt-5/qtwebengine-features.html#html5-drm >>> for reference >> >> I=E2=80=99m aware of this. My apologies for not expressing myself more >> clearly. We probably want to remove the support for the DRM plugin, >> following the discussions about ungoogled-chromium at >> >> https://issues.guix.gnu.org/issue/34565 > > I have attached a patch that disables support for loading the Widevine > plugin, and also removes unused bundled software from the source based > on a whitelist, similar to ungoogled-chromium's > %PRESERVED-THIRD-PARTY-FILES. > > It removes some 300+ MiB from the uncompressed sources. The snippet > will require some adjustments for every new version of QtWebEngine > however, I can help out with that when required. > > Patch 1/2 is a slightly "cleaned up" version of Mike's latest patch, > fixing some cosmetic issues, and makes it respect the daemons requested > number of build cores. > > With these changes, I think the package is ready to go. \o/ This is really great work Marius I appreciate this addition. I was actually just looking at this approach yesterday.=20 I've merged your two patches with one minor description addition that Hartm= ut requested. Hartmut the merged complete diff can be found here. https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine =20 Mike=20