From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:40452)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ituCI-0002Xc-Ry
 for guix-patches@gnu.org; Tue, 21 Jan 2020 09:08:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ituCH-0000aX-Rw
 for guix-patches@gnu.org; Tue, 21 Jan 2020 09:08:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:40673)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ituCH-0000aR-OQ
 for guix-patches@gnu.org; Tue, 21 Jan 2020 09:08:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ituCH-00024Q-KI
 for guix-patches@gnu.org; Tue, 21 Jan 2020 09:08:01 -0500
Subject: [bug#39093] [PATCH] gnu: Add emacs-vterm.
Resent-Message-ID: <handler.39093.B39093.15796156477915@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87r20549kt.fsf@lafreniere.xyz>
Date: Tue, 21 Jan 2020 15:07:10 +0100
In-Reply-To: <87r20549kt.fsf@lafreniere.xyz> (Joseph LaFreniere's message of
 "Sat, 11 Jan 2020 21:50:26 -0600")
Message-ID: <871rrsewdt.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 39093@debbugs.gnu.org

Hello Joseph,

"LaFreniere, Joseph" <joseph@lafreniere.xyz> skribis:

>>>From 06223ab2ed07b3fbfb2dfd95aa0a5fce1c44baf9 Mon Sep 17 00:00:00 2001
> From: Joseph LaFreniere <joseph@lafreniere.xyz>
> Date: Mon, 6 Jan 2020 20:56:35 -0600
> Subject: [PATCH] gnu: Add emacs-vterm.
>
> * gnu/packages/emacs-xyz.scm (emacs-vterm): New variable.

Neat!

> +                (modules '((guix build utils)))
> +                (snippet
> +                 '(begin
> +                    (delete-file "vterm-module-make.el")
> +                    (substitute* "vterm.el"
> +                      (((string-append "\\(or \\(require 'vterm-module n=
il t\\)\n"
> +                                       "^.*\\(and \\(require 'vterm-modu=
le-make\\)\n"
> +                                       "^.*\\(require 'vterm-module\\)\\=
)\\)"))
> +                       "(module-load \"vterm-module.so)"))
> +                    (make-file-writable "vterm.el")

Apparently this substitution doesn=E2=80=99t have the desired effect.  Also,
I strongly recommend using literal strings as patterns.

Actually, what about performing this substitution as a phase instead of
here?  We could probably use =E2=80=98emacs-substitute-sexps=E2=80=99 to do=
 that, which
should be nicer, and we could also hard-code the absolute file name of
=E2=80=98vterm-module.so=E2=80=99.

How does that sound?

The rest LGTM!

Thanks,
Ludo=E2=80=99.