From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58799) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNVXI-0002iZ-Dj for guix-patches@gnu.org; Sun, 12 Apr 2020 01:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNVXH-0005ui-4P for guix-patches@gnu.org; Sun, 12 Apr 2020 01:52:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNVXG-0005uU-0x for guix-patches@gnu.org; Sun, 12 Apr 2020 01:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNVXF-0003Wx-WC for guix-patches@gnu.org; Sun, 12 Apr 2020 01:52:01 -0400 Subject: [bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module. Resent-Message-ID: References: <87r1wte2ub.fsf@rohleder.de> In-reply-to: <87r1wte2ub.fsf@rohleder.de> Date: Sun, 12 Apr 2020 07:51:10 +0200 Message-ID: <871rotntf5.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 40568@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Good morning, Michael Rohleder =E5=86=99=E9=81=93=EF=BC=9A > My girlfriend's laptop has this chip, so I needed this to spread=20 > the > love of guix (to her already endless sea of love). Yay! Thank her for the patch. > Im not sure about the naming, it could also be something like > rtl8821ce-driver-linux. =2Dlinux-module's better. The currently random names should=20 probably be standardised. > + (define-public rtl8821ce-linux-module This can go under the existing rtl8812au-aircrack-ng-linux-module.=20 I knew that chip number looked familiar. > + (version (git-version "0.0.1" revision commit)) This should be 0.0.0 unless there's some 0.0.1 release of which=20 I'm unaware. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url=20 > "https://github.com/tomaspinho/rtl8821ce.git") > + (commit commit))) > + (sha256 > + (base32 > +=20 > "17jiw25k74kv5lnvgycvj2g1n06hbrpjz6p4znk4a62g136rhn4s")))) Git check-outs should have a (file-name (git-file-name name version)) field to make the store file name a bit nicer (and easier to=20 recognise). > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'build > + (lambda* (#:key inputs make-flags=20 > #:allow-other-keys) OK, I'm going to add #:make-flags support to l-m-b-s. > + (setenv "CC" "gcc") > + (apply invoke "make" > + (string-append "KSRC=3D" > + (assoc-ref inputs=20 > "linux-module-builder") > + "/lib/modules/build") > + (or make-flags '()))))) If you copied this from rtl8812au-aircrack-ng-linux-module I=20 apologise :-) I (and Guix) prefer specifying the default up-front=20 like so: (lambda* (#:key (make-flags '()) =E2=80=A6 #:allow-other-keys) =E2=80=A6 Then you can use it without ceremony. > + (synopsis "Linux Driver for Realtek RTL8821CE wireless=20 > network adapters") =E2=80=98driver=E2=80=99 > + (description "This is Realtek's RTL8821CE Linux driver=20 > for wireless Invisible trailing space. > +network adapters.") This ought to be a little longer. I can throw something together=20 if you're without inspiration. The AUR package says =E2=80=98with firmware=E2=80=99, which would be proble= matic=20 if I'd actually found any. The README also mentions firmware at=20 the very end. Do you know what they mean? Does this package work=20 out of the box with Linux-Libre? Is that only for Bluetooth? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6SrE4ACgkQ2Imw8BjF STxsDA//RXQ1Z1SCr760YDfZmkXcHj0ncwgDjnUIrQrCytTfDkmwv1rJO/33YwD5 OVWHMChhAW1gX2lgC1VBY51yRxmrH0gStbvKTob/pslTJptiLfgk5+FYunghSCQq Pq/OO2x1Ia3x02anjAKOZf0bCU8vWfNUJMh95z0VwNN7nZLL7+6QVaSP0KZyxcs7 ia1Hg69lm7Pdp7xFH70BLhCnCw6+HN1JG8hhHOCkhJC2s1tD3yM425l1IBBLt5a2 QR/7tK3nLWb5COanaoZglhfU4BzY9PSTxSpSXAmlxJHKi7Al0VY2FG6op1i8OHh2 FetE9N2fAzONCAfKFhYqQ7rq57l/WTGGggzw5MgvondvfLNRuEFn9tXMJA8Qj7KV I3WuhaTIFw1KEY6LUil9q5UcSCaRF7qJ+V9A3Mckzv8UWOwhWwA1qzEJwIbMK+p4 X6gF0jCL9QNL+NeZCN1cFL54o29rOOJxk5Ljq/UroCMqHikjLQuevPdvMbie6R6J 2ffIGK/2fHJJqmwbFa8NppNlAoy7Zh78ec3jumTeXQ0CAujkbImixvtLZzzdGvDN IueHPHuuoQHIk+lnh/iJcELuChI++yB8HcsiSeDNgL8anR0BRe+GiPdhIpru+py6 PxQN/XT7sbKhOloU/MgxOZGlQCft2iiiIvesKjzTMPd4AL6o0eE= =tfGd -----END PGP SIGNATURE----- --=-=-=--