[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[Michael Rohleder]

[-- Attachment #1.1: Type: text/plain, Size: 246 bytes --]

My girlfriend's laptop has this chip, so I needed this to spread the
love of guix (to her already endless sea of love).

Im not sure about the naming, it could also be something like
rtl8821ce-driver-linux.

So far (2 days), it works very well.


[-- Attachment #1.2: [PATCH] gnu: Add rtl8821ce-linux-module. --]
[-- Type: text/x-patch, Size: 2507 bytes --]

From 6332e69b7fedb614c404a434bcf35e217ce3a953 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sun, 12 Apr 2020 06:33:23 +0200
Subject: [PATCH] gnu: Add rtl8821ce-linux-module.

* gnu/packages/linux.scm (rtl8821ce-linux-module): New variable.
---
 gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0be50c11e0..a833aae236 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -42,6 +42,7 @@
 ;;; Copyright © 2020 Pierre Neidhardt <mail@ambrevar.xyz>
 ;;; Copyright © 2020 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1125,6 +1126,40 @@ module allows the control of the backlight level or luminance property when
 supported under @file{/sys/class/backlight/}.")
     (license license:gpl2+)))
 
+(define-public rtl8821ce-linux-module
+  (let ((commit "69765eb288a8dfad3b055b906760b53e02ab1dea")
+        (revision "0"))
+    (package
+      (name "rtl8821ce-linux-module")
+      (version (git-version "0.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/tomaspinho/rtl8821ce.git")
+               (commit commit)))
+         (sha256
+          (base32
+           "17jiw25k74kv5lnvgycvj2g1n06hbrpjz6p4znk4a62g136rhn4s"))))
+      (build-system linux-module-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (replace 'build
+             (lambda* (#:key inputs make-flags #:allow-other-keys)
+               (setenv "CC" "gcc")
+               (apply invoke "make"
+                      (string-append "KSRC="
+                                     (assoc-ref inputs "linux-module-builder")
+                                     "/lib/modules/build")
+                      (or make-flags '())))))
+         #:tests? #f))
+      (home-page "https://github.com/tomaspinho/rtl8821ce")
+      (synopsis "Linux Driver for Realtek RTL8821CE wireless network adapters")
+      (description "This is Realtek's RTL8821CE Linux driver for wireless 
+network adapters.")
+      (license license:gpl2))))
+
 \f
 ;;;
 ;;; Pluggable authentication modules (PAM).
-- 
2.26.0


[-- Attachment #1.3: Type: text/plain, Size: 106 bytes --]


-- 
When a Banker jumps out of a window, jump after him--that's where the money is.
		-- Robespierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 2656 bytes --]

Good morning,

Michael Rohleder 写道：
> My girlfriend's laptop has this chip, so I needed this to spread 
> the
> love of guix (to her already endless sea of love).

Yay!  Thank her for the patch.

> Im not sure about the naming, it could also be something like
> rtl8821ce-driver-linux.

-linux-module's better.  The currently random names should 
 probably be standardised.

> + (define-public rtl8821ce-linux-module

This can go under the existing rtl8812au-aircrack-ng-linux-module. 
I knew that chip number looked familiar.

> +      (version (git-version "0.0.1" revision commit))

This should be 0.0.0 unless there's some 0.0.1 release of which 
I'm unaware.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url 
> "https://github.com/tomaspinho/rtl8821ce.git")
> +               (commit commit)))
> +         (sha256
> +          (base32
> + 
> "17jiw25k74kv5lnvgycvj2g1n06hbrpjz6p4znk4a62g136rhn4s"))))

Git check-outs should have a

  (file-name (git-file-name name version))

field to make the store file name a bit nicer (and easier to 
recognise).

> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (replace 'build
> +             (lambda* (#:key inputs make-flags 
> #:allow-other-keys)

OK, I'm going to add #:make-flags support to l-m-b-s.

> +               (setenv "CC" "gcc")
> +               (apply invoke "make"
> +                      (string-append "KSRC="
> +                                     (assoc-ref inputs 
> "linux-module-builder")
> +                                     "/lib/modules/build")
> +                      (or make-flags '())))))

If you copied this from rtl8812au-aircrack-ng-linux-module I 
apologise :-)  I (and Guix) prefer specifying the default up-front 
like so:

  (lambda* (#:key (make-flags '()) … #:allow-other-keys) …

Then you can use it without ceremony.

> +      (synopsis "Linux Driver for Realtek RTL8821CE wireless 
> network adapters")

‘driver’

> +      (description "This is Realtek's RTL8821CE Linux driver 
> for wireless

Invisible trailing space.

> +network adapters.")

This ought to be a little longer.  I can throw something together 
if you're without inspiration.

The AUR package says ‘with firmware’, which would be problematic 
if I'd actually found any.  The README also mentions firmware at 
the very end.  Do you know what they mean?  Does this package work 
out of the box with Linux-Libre?  Is that only for Bluetooth?

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[Michael Rohleder]

[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]

Hi Tobias,

Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
writes:
> Yay!  Thank her for the patch.

Will do.

Thank you for your review!
Your suggestions are in the patch appended.

> This ought to be a little longer.  I can throw something together if
> you're without inspiration.

Yes, please do.

> The AUR package says ‘with firmware’, which would be problematic if
> I'd actually found any.  The README also mentions firmware at the very
> end.  Do you know what they mean?  Does this package work out of the
> box with Linux-Libre?  Is that only for Bluetooth?

idk what firmware they mean. This driver depends on cfg80211 which
shouldnt be a problem.
yes, this works out of the box with Linux-Libre (and not Libre) on the
laptop I have tested.
I havent tested bluetooth at all.


Kind Regards,
mike


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: Add rtl8821ce-linux-module --]
[-- Type: text/x-patch, Size: 2241 bytes --]

From b87d051b0ca74550df619e3cc8ed70e8f77f6e99 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sun, 12 Apr 2020 12:06:31 +0200
Subject: [PATCH] gnu: Add rtl8821ce-linux-module.

* gnu/packages/linux.scm (rtl8821ce-linux-module): New variable.
---
 gnu/packages/linux.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0be50c11e0..2365d309e4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1057,6 +1057,41 @@ and frame injection.  It provides a @code{88XXau} kernel module that supports
 RTL8812AU, RTL8821AU, and RTL8814AU chips.")
       (license license:gpl2+))))
 
+(define-public rtl8821ce-linux-module
+  (let ((commit "69765eb288a8dfad3b055b906760b53e02ab1dea")
+        (revision "0"))
+    (package
+      (name "rtl8821ce-linux-module")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/tomaspinho/rtl8821ce.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "17jiw25k74kv5lnvgycvj2g1n06hbrpjz6p4znk4a62g136rhn4s"))))
+      (build-system linux-module-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (replace 'build
+             (lambda* (#:key (make-flags '()) inputs #:allow-other-keys)
+               (setenv "CC" "gcc")
+               (invoke "make"
+                       (string-append "KSRC="
+                                      (assoc-ref inputs "linux-module-builder")
+                                      "/lib/modules/build")
+                       ))))
+         #:tests? #f))
+      (home-page "https://github.com/tomaspinho/rtl8821ce")
+      (synopsis "Linux driver for Realtek RTL8821CE wireless network adapters")
+      (description "This is Realtek's RTL8821CE Linux driver for wireless
+network adapters.")
+      (license license:gpl2))))
+
 (define-public vhba-module
   (package
     (name "vhba-module")
-- 
2.26.0


[-- Attachment #1.3: Type: text/plain, Size: 89 bytes --]


-- 
There are two types of hard drives: those that have failed, and those that will.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

Hi,

the upstream README mentions having to add "pci=noaer" to the kernel command
line sometimes.  Did you have to do that?

It also hints on "firmware" being necessary for "BlueTooth".

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40568] [PATCH] gnu: Add rtl8821ce-linux-module.

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:
> the upstream README mentions having to add "pci=noaer" to the kernel command
> line sometimes.  Did you have to do that?

No, I didnt, it worked w/o.

-- 
You can no more win a war than you can win an earthquake.
		-- Jeannette Rankin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#40568: [PATCH] gnu: Add rtl8821ce-linux-module.

[Ludovic Courtès]

Hi,

Michael Rohleder <mike@rohleder.de> skribis:

>> The AUR package says ‘with firmware’, which would be problematic if
>> I'd actually found any.  The README also mentions firmware at the very
>> end.  Do you know what they mean?  Does this package work out of the
>> box with Linux-Libre?  Is that only for Bluetooth?
>
> idk what firmware they mean. This driver depends on cfg80211 which
> shouldnt be a problem.
> yes, this works out of the box with Linux-Libre (and not Libre) on the
> laptop I have tested.
> I havent tested bluetooth at all.

[...]

> From b87d051b0ca74550df619e3cc8ed70e8f77f6e99 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Sun, 12 Apr 2020 12:06:31 +0200
> Subject: [PATCH] gnu: Add rtl8821ce-linux-module.
>
> * gnu/packages/linux.scm (rtl8821ce-linux-module): New variable.

Applied, thanks!

Ludo’.