From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47959) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOmIW-0005xB-SZ for guix-patches@gnu.org; Wed, 15 Apr 2020 13:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOmIV-0002DR-VB for guix-patches@gnu.org; Wed, 15 Apr 2020 13:58:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOmIU-00029S-Ba for guix-patches@gnu.org; Wed, 15 Apr 2020 13:58:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOmIU-0001Z8-8q for guix-patches@gnu.org; Wed, 15 Apr 2020 13:58:02 -0400 Subject: [bug#40543] [PATCH 4/4] gnu: virt-manager: Work towards enabling some tests. Resent-Message-ID: References: <87wo6n726x.fsf@cbaines.net> <20200410162157.21065-1-mail@cbaines.net> <20200410162157.21065-4-mail@cbaines.net> <87y2r3i8m5.fsf@devup.no> From: Christopher Baines In-reply-to: <87y2r3i8m5.fsf@devup.no> Date: Wed, 15 Apr 2020 18:57:31 +0100 Message-ID: <871roo7htg.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 40543@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> * gnu/packages/virtualization.scm (virt-manager)[arguments]: Set #:test-target >> to "test_ui", replace the 'check phase. >> [native-inputs]: Add some inputs required for running tests. > > [...] > >> @@ -673,6 +684,11 @@ virtualization library.") >> ("gobject-introspection" ,gobject-introspection) >> ("gtk+" ,gtk+ "bin") ; gtk-update-icon-cache >> ("perl" ,perl) ; pod2man >> + ("python-dogtail" ,python-dogtail) >> + ("xvfb" ,xorg-server) >> + ("dbus" ,dbus) >> + ("at-spi2-core" ,at-spi2-core) >> + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > > Please leave a comment along the lines of > > ;; The following are required for running the tests. > > ...to leave a clue for the next packager who wonders whether these > inputs are misplaced. > > Apart from these comments, the series LGTM. Sure, I've sent some new patches now with this change. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6XSwtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdnbBAAqIOjbKfnGZrDKmy9+xsJdaHslMztNJUe4yynCcclCyoRQ/8WgHjATXSz blgCaOIC0elxS+DwkqufR+OtlklEI9FFpY9EKh7NneSLDz6vz/wDuLDJ2eI/VG/+ LdUE6mUsVrlJZCGWVGwxxdtWdkV9dhzr+ClFufwD3hsotbwRobZHMwYAMHjn1k35 RmdnvdLlOBwPwdpjHv+I4scDUqVHPCA1PKzYs1Pk7n8qBg6nY5IXEthYoayy1zLt Wen8IUtPEHI+WKldeplTd1o+JABYIeR/Xxc75aRftZBlGVrbqYssiaT+25Z8ZBfp 3/2liwqiaxnTk8IRRetmLKymrFTi0a/x6HtIO53zuE0h0PNhtuuN4aIAsIdmzQFz USgcNEB8gdaGRnoS3wVOtldxrgZ/cNeJ/ONTso7s7uMzLIrestp4ykwcfA33JtlU Sufj/YE4oG7swyQmC79V3WeYrGcrK/7IqOvIuUG+wmP0EiIis6V2TfT3bkflk4dv dZPskYK4Uahb6IrCWnswqD+NpcjdGAnIme1thNiZWU69jD3NwueASluYBw/FiBIt sZs+Y/Bu8qxpqRi5+4i2phdWT+NVztCiZ8eRm58ZYMBp1q09op+rCTmMZiftXXFW UDPLnnEK8vqymc50ltR7W8bMksMQNtmXAXEHJiz6FlBeTJ2Sdxs= =rQQ2 -----END PGP SIGNATURE----- --=-=-=--