From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56221)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPU9q-0007tN-Vx
 for guix-patches@gnu.org; Fri, 17 Apr 2020 12:48:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPU9q-0006UJ-05
 for guix-patches@gnu.org; Fri, 17 Apr 2020 12:48:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58280)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jPU9p-0006Tq-ML
 for guix-patches@gnu.org; Fri, 17 Apr 2020 12:48:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPU9p-000727-Ko
 for guix-patches@gnu.org; Fri, 17 Apr 2020 12:48:01 -0400
Subject: [bug#40683] [PATCH] gnu: Add wireguard-module.
Resent-Message-ID: <handler.40683.B40683.158714207027016@debbugs.gnu.org>
References: <20200417155855.6210-1-brice@waegenei.re>
In-reply-to: <20200417155855.6210-1-brice@waegenei.re>
Date: Fri, 17 Apr 2020 18:47:49 +0200
Message-ID: <871romys7e.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
Reply-to: Tobias Geerinckx-Rice <me@tobias.gr>, Tobias Geerinckx-Rice via Guix-patches <guix-patches@gnu.org>
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 40683@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Brice!

Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A
> This patch add wireguard as a loadable Linux kernel module which=20
> allow using
> it Linux version < 5.6 without having to rebuild the entire=20
> kernel.

Thanks!

> +(define-public wireguard-module
> +  (package
> +    (inherit wireguard-linux-compat)
> +    (name "wireguard-module")

2x s/module/linux-module/

> +    (build-system linux-module-build-system)
> +    (arguments
> +     `(#:tests? #f                      ; No test suite
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'change-directory
> +           (lambda _
> +             (chdir "./src")
> +             #t)))))
> +    (synopsis "WireGuard loadable kernel module for Linux 3.10=20
> through 5.5")
> +    (description "This is a loadable Linux kernel module for=20
> WireGuard
> +supporting kernel versions 3.10 through 5.5.  WireGuard was=20
> added to Linux
> +5.6.

I think we should say =E2=80=98Linux-Libre=E2=80=99 here (yes, even though =
it=20
loads on any *Linux) but I'm never entirely sure.

> It ought to be used by adding it to the=20
> @code{kernel-loadable-modules}
> +field and loaded in memeory by @command{modprobe} or
> +@code{kernel-module-loader-service-type}.")))

This can go; it belongs in the manual and is already explained=20
there.

LGTM with these changes, but curious what others think about=20
=E2=80=98Linux=E2=80=99,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXpndtQAKCRANsP+IT1Vt
ebxOAP9BF2lbKju6ChQrRVM1GDecgzKCRQh5K38wJecpDoSWDAEAzxhQ8GBPKCmH
XSm5wuAFwDXJktG+fV250H1JVjqirAI=
=qBc2
-----END PGP SIGNATURE-----
--=-=-=--