From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Langlois Subject: Re: U-boot update revert. Date: Thu, 23 Apr 2020 21:46:09 +0200 Message-ID: <871roeq932.fsf@gmx.com> References: <87blni31gh.fsf@gmail.com> <87k126owtc.fsf@yucca> <87h7xaovxb.fsf@yucca> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:46776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRhnh-0004hC-CE for guix-devel@gnu.org; Thu, 23 Apr 2020 15:46:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRhng-00028T-Gc for guix-devel@gnu.org; Thu, 23 Apr 2020 15:46:21 -0400 Received: from mout.gmx.net ([212.227.17.20]:44919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jRhnf-0001tX-Pv for guix-devel@gnu.org; Thu, 23 Apr 2020 15:46:20 -0400 In-reply-to: <87h7xaovxb.fsf@yucca> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Vagrant Cascadian Cc: guix-devel@gnu.org Hi Vagrant and Mathieu, Vagrant Cascadian writes: > On 2020-04-23, Vagrant Cascadian wrote: >> On 2020-04-23, Mathieu Othacehe wrote: >>> I reverted the U-Boot update to 2020.04 because it breaks the build of >>> u-boot-tools package. Could you please have a look? >> >> Hrm. Pretty sure it worked locally when I committed it... >> >> Unfortunately, won't have a chance to debug till next week; if anyone >> else could look into it sooner that would be great! > > I did take the time to look at the failed build log: > > https://ci.guix.gnu.org/build/2602399/details > > But the log just cuts off for no apparent reason during the unpack > phase... I don't think the new u-boot is at fault there. > > > It built successfully on i686, armhf and aarch64 ... and the failed > x86_64 test is mysteriously absent? hrm: > > https://ci.guix.gnu.org/search?query=u-boot-tools-2020.04 > > But that's not hugely surprising, given that tests are not run on those > architectures. > > Honestly, the most of the test suite run for u-boot-tools is a generic > test suite for u-boot sandbox platforms, and most of the tests are > unrelated to what u-boot-tools actually provides, so I wonder if it's > even appropriate to run many of the tests as part of u-boot-tools... > > I'm not really sure the best way forward here. I noticed the revert today and got a chance to take a look, it seems u-boot-tools can't find sdl2: ``` make[2]: sdl2-config: Command not found make[2]: sdl2-config: Command not found make[2]: sdl2-config: Command not found make[2]: sdl2-config: Command not found ../arch/sandbox/cpu/sdl.c:10:10: fatal error: SDL2/SDL.h: No such file or directory #include ^~~~~~~~~~~~ compilation terminated. ``` Switching u-boot's dependency on sdl to sdl2 fixed it for me locally! I can send a patch tomorrow if nobody beats me to it :-) Thanks, Pierre