From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id zyp4Oq6erV5QYgAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 16:24:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eHD7EbierV7CMwAAB5/wlQ (envelope-from ) for ; Sat, 02 May 2020 16:24:24 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79413941C13 for ; Sat, 2 May 2020 16:24:23 +0000 (UTC) Received: from localhost ([::1]:53724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUuqg-0002uK-94 for larch@yhetil.org; Sat, 02 May 2020 12:18:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUuqP-0002lH-Bs for guix-devel@gnu.org; Sat, 02 May 2020 12:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUuqO-00039k-3p for guix-devel@gnu.org; Sat, 02 May 2020 12:18:24 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:35413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUuqM-00039K-W4 for guix-devel@gnu.org; Sat, 02 May 2020 12:18:23 -0400 Received: from mimimi (moi44-1-78-199-129-170.fbx.proxad.net [78.199.129.170]) (Authenticated sender: mail@ambrevar.xyz) by relay11.mail.gandi.net (Postfix) with ESMTPSA id E7743100002; Sat, 2 May 2020 16:18:19 +0000 (UTC) From: Pierre Neidhardt To: Marius Bakke , guix-devel@gnu.org Subject: Re: branch master updated: gnu: Add warsow-qfusion. In-Reply-To: <87d07m2wnz.fsf@devup.no> References: <20200502135735.22136.31429@vcs0.savannah.gnu.org> <87ftci2y7p.fsf@devup.no> <878siacrr1.fsf@ambrevar.xyz> <87d07m2wnz.fsf@devup.no> Date: Sat, 02 May 2020 18:18:17 +0200 Message-ID: <871ro2cnue.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=217.70.178.231; envelope-from=mail@ambrevar.xyz; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/02 12:18:20 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 217.70.178.231 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -0.61 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-0.61 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49511334632625]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_MISSING_CHARSET(2.50)[]; DWL_DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[fastmail.com,gnu.org]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[mail@ambrevar.xyz,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[fastmail.com:email,ambrevar.xyz:url]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_NA(0.00)[]; DMARC_NA(0.00)[ambrevar.xyz]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_SPAMHAUS_PBL(0.00)[78.199.129.170:received]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: qSk31GvF0Cap --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: >>> + (let ((commit "c4de15df559410aff0ca6643724e24cddb0ecbbd") >>> + (arch (match (or (%current-target-system) >>> + (%current-system)) >>> + ("x86_64-linux" "x86_64") >>> + ("i686-linux" "i386") >>> + (_ "")))) >>> Don't do this if you just need to determine architecture at build time. >> >> Just to be sure, you suggest moving this inside the 'really-install >> phase, right? > > Yes. Otherwise it gets needlessly evaluated by the Guix "front-end" > every time one uses 'guix search' etc -- even on unsupported > architectures. It's better to do it at build time, especially when it > is only used within a single phase. I don't understand the difference. (match (or (%current-target-system) (%current-system)) ("x86_64-linux" "x86_64") ("i686-linux" "i386")) must be unquoted inside the phase, so it's evaluated when the package is and not at build time, isn't it? Else how do you match against the build architecture at build time? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl6tnUkACgkQm9z0l6S7 zH/7rwf/Q+jWAsUVqJBlHzwiViZOOztzahLYykj7am3GJFAjlE+a2AD1ScKMi3Lu ygZBAYDjm2W1FSeK8BxBTrBhJtDNrP9IIoZPcSkquein1YtXSzPSuT8WR1LRJ/ZQ O6eDVSMVYg7M1jl3MlpNP1evAdaS1nSyze4L88wX9x67gtVzmfPiAIkMXucUAFi4 LElkiRZsLM+FDLeTbN7gr3s3wj1LCnRAzcMkjW59kyAZXGhugOOWY5p7JcnceUnG tQzo/OrZgSGYHlThsXkk0bBh0biHE9nDK4fMWLtIbGwUFCW6RcA56eQ1GXZmWMzL Htp73MqkToM51DGw9IBHo85RH43MxQ== =bZV0 -----END PGP SIGNATURE----- --=-=-=--