From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SDC4M8FJ2154agAA0tVLHw (envelope-from ) for ; Sat, 06 Jun 2020 07:46:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mIB7L8FJ217iZwAAbx9fmQ (envelope-from ) for ; Sat, 06 Jun 2020 07:46:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26C98940539 for ; Sat, 6 Jun 2020 07:46:09 +0000 (UTC) Received: from localhost ([::1]:49482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhTWo-0002Kk-IV for larch@yhetil.org; Sat, 06 Jun 2020 03:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhTWk-0002KO-M7 for guix-patches@gnu.org; Sat, 06 Jun 2020 03:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhTWk-0003hq-D7 for guix-patches@gnu.org; Sat, 06 Jun 2020 03:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhTWk-0005NE-AG for guix-patches@gnu.org; Sat, 06 Jun 2020 03:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Jun 2020 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41731 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Cc: 41731@debbugs.gnu.org Received: via spool by 41731-submit@debbugs.gnu.org id=B41731.159142950720573 (code B ref 41731); Sat, 06 Jun 2020 07:46:02 +0000 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 07:45:07 +0000 Received: from localhost ([127.0.0.1]:50593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTVr-0005Ll-0E for submit@debbugs.gnu.org; Sat, 06 Jun 2020 03:45:07 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:51727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTVo-0005Kr-Qn for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 03:45:05 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D615CC0008; Sat, 6 Jun 2020 07:44:57 +0000 (UTC) From: Nicolas Goaziou References: <20200605233349.140049-1-plattfot@gmail.com> Date: Sat, 06 Jun 2020 09:44:56 +0200 In-Reply-To: <20200605233349.140049-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Fri, 5 Jun 2020 16:33:49 -0700") Message-ID: <871rmsab9j.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 0O6rncpzyE+G Hello, Fredrik Salomonsson writes: > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. Thank you. Some comments follow. > + (propagated-inputs > + `(("shellcheck" ,shellcheck))) I don't think we should do that. It is up to the user to install ShellCheck if they want. For example, installing `emacs-flycheck-haskell' doesn't pull GHC in user's profile. > + (home-page "https://github.com/federicotdn/flymake-shellcheck") > + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") > + (description > + "This package provides a backend for Flymake (emacs-26+) to use the Nitpick: you can remove the (emacs-26+) part. > +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh} Nitpick: since you seem to talk about the tool as a whole, I suggest: @command{shellcheck} -> ShellCheck > +scripts. Please see the description on @command{shellcheck} for more > +information on what it can do." I think you can remove the last sentence. Could you send an updated patch? Regards, -- Nicolas Goaziou